From: Auke Kok <auke-jan.h.kok@intel.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
"bibo,mao" <bibo.mao@intel.com>,
Rajesh Shah <rajesh.shah@intel.com>,
Grant Grundler <grundler@parisc-linux.org>,
akpm@osdl.org, LKML <linux-kernel@vger.kernel.org>,
linux-pci maillist <linux-pci@atrey.karlin.mff.cuni.cz>,
netdev@vger.kernel.org
Subject: Re: [PATCH] ixgb: add PCI Error recovery callbacks
Date: Wed, 05 Jul 2006 08:49:27 -0700 [thread overview]
Message-ID: <44ABDF87.8000801@intel.com> (raw)
In-Reply-To: <1151905766.28493.129.camel@ymzhang-perf.sh.intel.com>
Zhang, Yanmin wrote:
> On Fri, 2006-06-30 at 00:26, Linas Vepstas wrote:
>> Adds PCI Error recovery callbacks to the Intel 10-gigabit ethernet
>> ixgb device driver. Lightly tested, works.
>
> Both pci_disable_device and ixgb_down would access the device. It doesn't
> follow Documentation/pci-error-recovery.txt that error_detected shouldn't do
> any access to the device.
Moreover, it was Linas who wrote this documentation in the first place :)
Linas, have you tried moving the e1000_down() call into the _reset part? I
suspect that the e1000_reset() in there however may already be sufficient.
Cheers,
Auke
next prev parent reply other threads:[~2006-07-05 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-29 16:26 [PATCH] ixgb: add PCI Error recovery callbacks Linas Vepstas
2006-07-03 5:49 ` Zhang, Yanmin
2006-07-05 15:49 ` Auke Kok [this message]
2006-07-05 19:44 ` Linas Vepstas
2006-07-06 1:21 ` Zhang, Yanmin
2006-07-06 16:16 ` Linas Vepstas
2006-07-06 18:01 ` Auke Kok
2006-07-06 18:50 ` Linas Vepstas
2006-07-06 21:52 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44ABDF87.8000801@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=akpm@osdl.org \
--cc=bibo.mao@intel.com \
--cc=grundler@parisc-linux.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=netdev@vger.kernel.org \
--cc=rajesh.shah@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.