From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Gardner Subject: Re: [PATCH] xenmon: remove magic number "31" (the idle domain) Date: Wed, 05 Jul 2006 10:22:25 -0600 Message-ID: <44ABE741.5000606@hp.com> References: <20060704.143731.74693697.kuwa@jp.fujitsu.com> <2a7a55c7de2d697c126797c1fb982850@cl.cam.ac.uk> <20060704.164820.78765530.kuwa@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: KUWAMURA Shin'ya , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: >> Therefore, xenmon supports only up to 32 domains. > > That's poor, since it in fact only really supports the first 31 > domains created on a system (domain ids don't necessarily quickly get > reused; and 32nd domid is used as sentinel to indicate idle). It > shouldn't be hard to use a data structure more complicated than > (presumably) a small array indexed by domid. I know about this problem. I've got a fix for it I prepared some time ago but never got around to submitting. I'll integrate it with the latest source and get it sent out this week. Rob