All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: open-iscsi@googlegroups.com, linux-scsi <linux-scsi@vger.kernel.org>
Subject: [PATCH] fix session release module reference
Date: Wed, 05 Jul 2006 13:52:21 -0500	[thread overview]
Message-ID: <44AC0A65.6000101@cs.wisc.edu> (raw)
In-Reply-To: <D4F8F0B3820E754C887699BEF26A89404A72ED@taurus.voltaire.com>

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

James,

Attached is a mail and patch from the iser maintainer that fixes a bug
in the patchset we just sent where we free a struct then try to
reference it later. The patch was made over scsi-misc. If it is not too
late it could go into rc1. If it is too late then I will resend it with
my other bugfixe patches we had queued up and are testing.


Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>


Or Gerlitz wrote:
> Mike said he might be busy these days, so i need some help from people on this list
> to validate that indeed the patches pushed to Linus break iscsi in session_destroy
> so we can send upstream a fixing patch (eg in the spirit of  the attached).
> 


[-- Attachment #2: session_teardown2.patch --]
[-- Type: text/x-patch, Size: 680 bytes --]

diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 7e6e031..ca590cd 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -1322,6 +1322,7 @@ void iscsi_session_teardown(struct iscsi
 {
 	struct Scsi_Host *shost = iscsi_session_to_shost(cls_session);
 	struct iscsi_session *session = iscsi_hostdata(shost->hostdata);
+	struct module *owner = cls_session->transport->owner;
 
 	scsi_remove_host(shost);
 
@@ -1330,7 +1331,7 @@ void iscsi_session_teardown(struct iscsi
 
 	iscsi_destroy_session(cls_session);
 	scsi_host_put(shost);
-	module_put(cls_session->transport->owner);
+	module_put(owner);
 }
 EXPORT_SYMBOL_GPL(iscsi_session_teardown);
 

           reply	other threads:[~2006-07-05 18:52 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <D4F8F0B3820E754C887699BEF26A89404A72ED@taurus.voltaire.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44AC0A65.6000101@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=linux-scsi@vger.kernel.org \
    --cc=open-iscsi@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.