From: Jeff Garzik <jeff@garzik.org>
To: Willy Tarreau <w@1wt.eu>
Cc: marcelo@kvack.org, davem@davemloft.net, matthew@wil.cx,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH-2.4] 2 oopses in ethtool
Date: Wed, 05 Jul 2006 17:29:53 -0400 [thread overview]
Message-ID: <44AC2F51.7070804@garzik.org> (raw)
In-Reply-To: <20060705204706.GA254@1wt.eu>
Willy Tarreau wrote:
> Hi Marcelo,
>
> I got an oops today with 2.4.33-rc2 when playing ethtool games on my TG3
> NIC. It was caused by a typo in ethtool.c, and while fixing it, I discovered
> a second one.
>
> David, a quick check showed that 2.6.17.1 has the first one fixed but not
> second one (ethtool_set_pauseparam), so you might want to merge it too.
>
> Cheers,
> Willy
>
> From: Willy Tarreau <willy@wtap.(none)>
> Date: Wed, 5 Jul 2006 22:34:52 +0200
> Subject: [PATCH] ethtool: two oopses in ethtool_set_coalesce() and ethtool_set_pauseparam()
>
> The function pointers which were checked were for their get_* counterparts.
> Typically a copy-paste typo.
>
> Signed-off-by: Willy Tarreau <w@1wt.eu>
ACK
prev parent reply other threads:[~2006-07-05 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 20:47 [PATCH-2.4] 2 oopses in ethtool Willy Tarreau
2006-07-05 21:29 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44AC2F51.7070804@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@kvack.org \
--cc=matthew@wil.cx \
--cc=stable@kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.