From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: cosmetic, replace ap_lock w/ ap->lock in ata_scsi_error()
Date: Wed, 05 Jul 2006 22:06:21 -0400 [thread overview]
Message-ID: <44AC701D.4010107@pobox.com> (raw)
In-Reply-To: <20060702180215.GB6027@htj.dyndns.org>
Tejun Heo wrote:
> ap_lock was used because &ap->host_set->lock was too long and used a
> lot. Now that &ap->host_set->lock is replaced with ap->lock, there's
> no reason to keep ap_lock.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
applied, though I removed "cosmetic" from the subject line, and added
this note to the changelog:
[ed. note: that's not entirely true. ap_lock is a local variable,
caching the results of a de-ref. In theory, if the compiler is smart
enough, this patch is cosmetic. However, since this is not a fast
path (it is the error path), this patch is nonetheless acceptable,
even though it _may_ introduce a performance regression.]
prev parent reply other threads:[~2006-07-06 2:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-02 18:02 [PATCH] libata: cosmetic, replace ap_lock w/ ap->lock in ata_scsi_error() Tejun Heo
2006-07-06 2:06 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44AC701D.4010107@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.