All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Haumer <andreas@xss.co.at>
To: linux-kernel@vger.kernel.org
Cc: marcelo@kvack.org, w@1wt.eu
Subject: [PATCH-2.4] Typo in cdrom.c also in linux-2.4
Date: Thu, 06 Jul 2006 10:23:12 +0200	[thread overview]
Message-ID: <44ACC870.2000609@xss.co.at> (raw)

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Marcelo,
hi Willy,

are you aware of the discussion at
<http://bugzilla.kernel.org/show_bug.cgi?id=2966> ?

The typo seems to exist in linux-2.4 too, at least in
2.4.32, 2.4.32-hf32.6 and 2.4.33pre3 (which is what
I checked today)

The fix for linux-2.4 would be just like the proposed
patch for linux-2.6 (see attachment)

Comments?

- - andreas

- --
Andreas Haumer                     | mailto:andreas@xss.co.at
*x Software + Systeme              | http://www.xss.co.at/
Karmarschgasse 51/2/20             | Tel: +43-1-6060114-0
A-1100 Vienna, Austria             | Fax: +43-1-6060114-71
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFErMhbxJmyeGcXPhERAgw6AKCwDRtEyE1EK+oT/nU5v2ysQxmWqACcDh1y
eZq4acxsutVuP68nDDcEeAE=
=puYc
-----END PGP SIGNATURE-----

[-- Attachment #2: cdrom.c.patch --]
[-- Type: text/x-patch, Size: 583 bytes --]

Index: cdrom.c
===================================================================
RCS file: /home/cvs/repository/distribution/Base/linux/drivers/cdrom/cdrom.c,v
retrieving revision 1.1.1.10
diff -u -r1.1.1.10 cdrom.c
--- cdrom.c	19 Jan 2005 14:09:43 -0000	1.1.1.10
+++ cdrom.c	6 Jul 2006 08:22:06 -0000
@@ -1259,7 +1259,7 @@
 	init_cdrom_command(&cgc, buf, sizeof(buf), CGC_DATA_READ);
 	cgc.cmd[0] = GPCMD_READ_DVD_STRUCTURE;
 	cgc.cmd[7] = s->type;
-	cgc.cmd[9] = cgc.buflen = 0xff;
+	cgc.cmd[9] = cgc.buflen & 0xff;
 
 	if ((ret = cdo->generic_packet(cdi, &cgc)))
 		return ret;

             reply	other threads:[~2006-07-06  8:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-06  8:23 Andreas Haumer [this message]
2006-07-06  8:33 ` [PATCH-2.4] Typo in cdrom.c also in linux-2.4 Willy Tarreau
2006-07-06  8:35 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44ACC870.2000609@xss.co.at \
    --to=andreas@xss.co.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@kvack.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.