All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henne <henne@nachtwindheim.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
	Neela.Kolli@engenio.com, kernel-janitors@lists.osdl.org,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [KJ] [PATCH] fix legacy megaraid-driver to compile without
Date: Fri, 07 Jul 2006 06:32:10 +0000	[thread overview]
Message-ID: <44ADFFEA.1060508@nachtwindheim.de> (raw)
In-Reply-To: <20060706215957.GX26941@stusta.de>

>> The header I mean is /drivers/scsi/megaraid.h and is only used by megaraid.c.
>> And there are the prototypes, in dependency of CONFIG_PROC_FS, for all these other proc-related functions.
>> Thats why I decided to make the change there and not in megaraid.c .
> 
> Prototypes for static functions don't belong into header files.
> 
> That this has been done in megaraid.h in the past is something that 
> should be cleaned up, not a good example.
> 
> cu
> Adrian
Allright,
thats that kind of answer I wanted to hear. :)

Thanks and Greets,
Henne


_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Henne <henne@nachtwindheim.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
	Neela.Kolli@engenio.com, kernel-janitors@lists.osdl.org,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [KJ] [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS
Date: Fri, 07 Jul 2006 08:32:10 +0200	[thread overview]
Message-ID: <44ADFFEA.1060508@nachtwindheim.de> (raw)
In-Reply-To: <20060706215957.GX26941@stusta.de>

>> The header I mean is /drivers/scsi/megaraid.h and is only used by megaraid.c.
>> And there are the prototypes, in dependency of CONFIG_PROC_FS, for all these other proc-related functions.
>> Thats why I decided to make the change there and not in megaraid.c .
> 
> Prototypes for static functions don't belong into header files.
> 
> That this has been done in megaraid.h in the past is something that 
> should be cleaned up, not a good example.
> 
> cu
> Adrian
Allright,
thats that kind of answer I wanted to hear. :)

Thanks and Greets,
Henne



  reply	other threads:[~2006-07-07  6:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-06 19:54 [KJ] [PATCH] fix legacy megaraid-driver to compile without Henne
2006-07-06 19:54 ` [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS Henne
2006-07-06 20:14 ` [KJ] [PATCH] fix legacy megaraid-driver to compile without Randy.Dunlap
2006-07-06 20:14   ` [KJ] [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS Randy.Dunlap
2006-07-06 20:33   ` [KJ] [PATCH] fix legacy megaraid-driver to compile without Henne
2006-07-06 20:33     ` [KJ] [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS Henne
2006-07-06 20:39     ` [KJ] [PATCH] fix legacy megaraid-driver to compile without Randy.Dunlap
2006-07-06 20:39       ` [KJ] [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS Randy.Dunlap
2006-07-06 20:42     ` [KJ] [PATCH] fix legacy megaraid-driver to compile without Adrian Bunk
2006-07-06 20:42       ` [KJ] [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS Adrian Bunk
2006-07-06 20:54       ` [KJ] [PATCH] fix legacy megaraid-driver to compile without Henne
2006-07-06 20:54         ` [KJ] [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS Henne
2006-07-06 21:59         ` [KJ] [PATCH] fix legacy megaraid-driver to compile without Adrian Bunk
2006-07-06 21:59           ` [KJ] [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS Adrian Bunk
2006-07-07  6:32           ` Henne [this message]
2006-07-07  6:32             ` Henne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44ADFFEA.1060508@nachtwindheim.de \
    --to=henne@nachtwindheim.de \
    --cc=Neela.Kolli@engenio.com \
    --cc=bunk@stusta.de \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.