All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Bob Tracy <rct@gherkin.frus.com>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.18-rc1 build error (YACC): followup
Date: Fri, 07 Jul 2006 16:54:34 -0700	[thread overview]
Message-ID: <44AEF43A.5020308@zytor.com> (raw)
In-Reply-To: <20060707223650.GB28811@mars.ravnborg.org>

Sam Ravnborg wrote:
> On Fri, Jul 07, 2006 at 03:24:42PM -0500, Bob Tracy wrote:
>> I wrote:
>>> $YACC now seems to be undefined when I do a "make bzImage" and the
>>> build process gets to drivers/scsi/aic7xxx/aicasm (with the aic7xxx
>>> driver configured as a built-in).  As a workaround, it's possible to
>>> "cd" into the indicated directory and run "make" directly.  Once the
>>> default build completes, restarting "make bzImage" from the kernel
>>> source root continues as expected.
>> Found it.  The main "Makefile" has "MAKEFLAGS += -rR" uncommented as
>> of 2.6.18-rc1.  The deleted comment about "possibly random breakage"
>> that used to be just above that line pretty much says it all :-).
> I have now applied a patch where YACC= bison is dined in
> aicasm/Makefile.
> There are no other $(YACC) users in the kernel - the others specify bison
> direct.
> 

I propose the following as a global yacc rule; already used in usr/dash 
in the klibc tree, and which seems to work for both bison and BSD yacc:

quiet_cmd_yacc = YACC    $@
       cmd_yacc = $(YACC) -d -o $@ $<

$(obj)/%.c %(obj)/%.h: $(src)/%.y
         $(call cmd,yacc)


Note that bison seems to make smaller code than yacc, so I definiteily 
think we should default to bison over yacc.

	-hpa


  reply	other threads:[~2006-07-07 23:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-07 20:24 2.6.18-rc1 build error (YACC): followup Bob Tracy
2006-07-07 20:36 ` Sam Ravnborg
2006-07-07 22:36 ` Sam Ravnborg
2006-07-07 23:54   ` H. Peter Anvin [this message]
2006-07-09 13:38     ` Sam Ravnborg
2006-07-09 18:28       ` H. Peter Anvin
2006-07-10 12:46         ` Bob Tracy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44AEF43A.5020308@zytor.com \
    --to=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rct@gherkin.frus.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.