From: Robert Schulze <rob@net-pr.de>
To: netdev@vger.kernel.org
Cc: linville@tuxdriver.com
Subject: [PATCH] airo: make debug-like messages printed by airo_print_dbg()
Date: Sat, 08 Jul 2006 17:59:13 +0200 [thread overview]
Message-ID: <44AFD651.8030801@net-pr.de> (raw)
I don't think that messages like
airo(eth1): cmd= 111
airo(eth1): status= 7f11
airo(eth1): Rsp0= 2
airo(eth1): Rsp1= 0
airo(eth1): Rsp2= 0
are interesting to normal users, so switch them from airo_print_err() to airo_print_dbg().
Furthermore, remove implicit linefeed in those messages, as they are handled by airo_print().
with kind regards,
Robert Schulze
--- linux-2.6.17.1/drivers/net/wireless/airo.c.orig 2006-07-08 14:02:12.000000000 +0200
+++ linux-2.6.17.1/drivers/net/wireless/airo.c 2006-07-08 17:36:08.000000000 +0200
@@ -3897,11 +3897,11 @@ static u16 issuecommand(struct airo_info
pRsp->rsp1 = IN4500(ai, RESP1);
pRsp->rsp2 = IN4500(ai, RESP2);
if ((pRsp->status & 0xff00)!=0 && pCmd->cmd != CMD_SOFTRESET) {
- airo_print_err(ai->dev->name, "cmd= %x\n", pCmd->cmd);
- airo_print_err(ai->dev->name, "status= %x\n", pRsp->status);
- airo_print_err(ai->dev->name, "Rsp0= %x\n", pRsp->rsp0);
- airo_print_err(ai->dev->name, "Rsp1= %x\n", pRsp->rsp1);
- airo_print_err(ai->dev->name, "Rsp2= %x\n", pRsp->rsp2);
+ airo_print_dbg(ai->dev->name, "cmd= %x", pCmd->cmd);
+ airo_print_dbg(ai->dev->name, "status= %x", pRsp->status);
+ airo_print_dbg(ai->dev->name, "Rsp0= %x", pRsp->rsp0);
+ airo_print_dbg(ai->dev->name, "Rsp1= %x", pRsp->rsp1);
+ airo_print_dbg(ai->dev->name, "Rsp2= %x", pRsp->rsp2);
}
// clear stuck command busy if necessary
next reply other threads:[~2006-07-08 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-08 15:59 Robert Schulze [this message]
2006-07-09 14:24 ` [PATCH] airo: make debug-like messages printed by airo_print_dbg() Dan Williams
2006-07-09 17:14 ` Robert Schulze
2006-07-09 17:55 ` Michael Tokarev
2006-07-09 22:23 ` Robert Schulze
2006-07-10 3:12 ` Dan Williams
2006-07-10 16:37 ` Robert Schulze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44AFD651.8030801@net-pr.de \
--to=rob@net-pr.de \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.