From: Patrick McHardy <kaber@trash.net>
To: Phil Oester <kernel@linuxace.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] iptables: handle cidr notation more sanely
Date: Mon, 10 Jul 2006 06:26:38 +0200 [thread overview]
Message-ID: <44B1D6FE.6080208@trash.net> (raw)
In-Reply-To: <20060709222818.GA23200@linuxace.com>
Phil Oester wrote:
> At present, a command such as
>
> iptables -A foo -s 10.10/16
>
> will interpret 10.10/16 as 10.0.0.10/16, and after applying the mask end
> up with 10.0.0.0/16, which likely isn't what the user intended. Yet
> some people do expect 10.10 (without the cidr notation) to end up as
> 10.0.0.10.
>
> The below patch should satisfy all parties. It zero pads the missing
> octets only in the cidr case, leaving the IP untouched otherwise.
>
> This resolves bug #422
Applied, thanks Phil. Hope all those lazy typers are happy now :)
next prev parent reply other threads:[~2006-07-10 4:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-09 22:28 [PATCH] iptables: handle cidr notation more sanely Phil Oester
2006-07-10 4:26 ` Patrick McHardy [this message]
2006-07-10 5:59 ` Patrick Schaaf
2006-07-10 6:43 ` Patrick McHardy
2006-07-10 6:52 ` Patrick Schaaf
2006-07-10 7:24 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B1D6FE.6080208@trash.net \
--to=kaber@trash.net \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.