All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@pol.net>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Jean Delvare <khali@linux-fr.org>, Andrew Morton <akpm@osdl.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
Date: Mon, 10 Jul 2006 19:27:07 +0800	[thread overview]
Message-ID: <44B2398B.7040300@pol.net> (raw)
In-Reply-To: <m3mzbh68g9.fsf@defiant.localdomain>

Krzysztof Halasa wrote:
> "Antonino A. Daplas" <adaplas@pol.net> writes:
> 
>> There are better reasons (ie, smaller patch), but worse readability is not
>> one of them.
>>
>> I could more easily grasp the code flow of cirrusfb_register() if you
>> just inserted "cirrusfb_create_i2c_buses()" instead of:
> 
> Feel free to add another patch, while I don't see a need I have nothing
> against :-)

No, you fix the patch.  And while your at it, check your Kconfig
dependencies, ie check for impossible combinations such as CONFIG_I2C=m,
CONFIG_FB_CIRRUS=y.

Tony

  reply	other threads:[~2006-07-10 11:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200607050147.k651kxmT023763@shell0.pdx.osdl.net>
     [not found] ` <20060705165255.ab7f1b83.khali@linux-fr.org>
2006-07-09 20:37   ` [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch Krzysztof Halasa
2006-07-09 23:53     ` Antonino A. Daplas
2006-07-10  9:49       ` Krzysztof Halasa
2006-07-10 10:07         ` Antonino A. Daplas
2006-07-10 10:49           ` Krzysztof Halasa
2006-07-10 11:27             ` Antonino A. Daplas [this message]
2006-07-10 11:49               ` Krzysztof Halasa
2006-07-10 12:32                 ` Antonino A. Daplas
2006-07-10 13:09                   ` Krzysztof Halasa
2006-07-10 14:29                     ` Antonino A. Daplas
2006-07-10 14:46                       ` Krzysztof Halasa
2006-07-27 21:23                       ` Jean Delvare
2006-07-10 13:27                   ` Krzysztof Halasa
2006-07-10 14:11                     ` Antonino A. Daplas
2006-07-10 15:37                       ` Krzysztof Halasa
2006-07-10 16:30                         ` Antonino A. Daplas
2006-07-10 20:34                           ` Krzysztof Halasa
2006-07-11  7:22                             ` Antonino A. Daplas
2006-07-11 10:53                               ` Krzysztof Halasa
2006-07-27 20:55                                 ` Jean Delvare
2006-07-28 10:05                                   ` Krzysztof Halasa
2006-07-10 15:18                     ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44B2398B.7040300@pol.net \
    --to=adaplas@pol.net \
    --cc=akpm@osdl.org \
    --cc=khali@linux-fr.org \
    --cc=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.