From: "Rafał Bilski" <rafalbilski@interia.pl>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: cpufreq@lists.linux.org.uk
Subject: [PATCH] Longhaul - Only for "Powersaver"
Date: Thu, 13 Jul 2006 07:57:49 +0200 [thread overview]
Message-ID: <44B5E0DD.9090109@interia.pl> (raw)
Looks like ACPI C3 don't work with older VIA CPUs. Motherboard is
ACPI C3 capable, but after C3 frequency is same as before.
So this patch below will make "longhaul" fail for older CPU's.
There is nothing what I can do to fix this. Looks like CPU with
BCR2 MSR is changing frequency only on halt. Processor with
Longhaul MSR is changing frequency on halt or ACPI C3.
Btw typo fixes.
Thanks to David for bug report.
Signed-off-by: Rafa³ Bilski <rafalbilski@interia.pl>
---
diff -uprN -X linux-2.6.17-git20-vanilla/Documentation/dontdiff linux-2.6.17-git20-vanilla/arch/i386/kernel/cpu/cpufreq/longhaul.c linux-2.6.17-git20/arch/i386/kernel/cpu/cpufreq/longhaul.c
--- linux-2.6.17-git20-vanilla/arch/i386/kernel/cpu/cpufreq/longhaul.c 2006-07-13 07:39:41.000000000 +0200
+++ linux-2.6.17-git20/arch/i386/kernel/cpu/cpufreq/longhaul.c 2006-07-13 07:38:35.000000000 +0200
@@ -550,7 +550,7 @@ static int __init longhaul_cpu_init(stru
if (pr == NULL) goto err_acpi;
cx = &pr->power.states[ACPI_STATE_C3];
- if (cx == NULL || cx->latency > 1000) goto err_acpi;
+ if (cx->address == 0 || cx->latency > 1000) goto err_acpi;
/* Now check what we have on this motherboard */
switch (c->x86_model) {
@@ -627,7 +627,9 @@ static int __init longhaul_cpu_init(stru
switch (longhaul_version) {
case TYPE_LONGHAUL_V1:
case TYPE_LONGHAUL_V2:
- printk ("Longhaul v%d supported.\n", longhaul_version);
+// printk ("Longhaul v%d supported.\n", longhaul_version);
+ printk(KERN_ERR PFX "Processor don't support ACPI. Aborting.\n");
+ return -ENODEV;
break;
case TYPE_POWERSAVER:
printk ("Powersaver supported.\n");
@@ -691,8 +693,8 @@ static int __init longhaul_init(void)
#ifdef CONFIG_SMP
if (num_online_cpus() > 1) {
- return -ENODEV;
printk(KERN_ERR PFX "More than 1 CPU detected, longhaul disabled.\n");
+ return -ENODEV;
}
#endif
#ifdef CONFIG_X86_IO_APIC
--------------------------------------------------------------------
12 000 SMS-ow gratis! Promocja na http://link.interia.pl/f1971
next reply other threads:[~2006-07-13 5:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-13 5:57 Rafał Bilski [this message]
2006-07-13 6:27 ` [PATCH] Longhaul - Only for "Powersaver" Dave Jones
2006-07-13 6:59 ` Rafał Bilski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B5E0DD.9090109@interia.pl \
--to=rafalbilski@interia.pl \
--cc=cpufreq@lists.linux.org.uk \
--cc=davej@codemonkey.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.