All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Ludvig <michal@logix.cz>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [CRYPTO] padlock: Fix alignment after aes_ctx rearrange
Date: Fri, 14 Jul 2006 14:08:16 +1200	[thread overview]
Message-ID: <44B6FC90.2060501@logix.cz> (raw)

Hi Herbert,

I just recently discovered that your patch that rearranges struct
aes_ctx in padlock-aes.c breaks the alignment rules for xcrypt leading
to GPF Oopses.

Note that *all* addresses passed to xcrypt must be 16-Bytes aligned for
VIA C3 (including IV and Key - the latter one was not aligned and
triggered this Oops).

As the rearrange patch made it to 2.6.18-rc1 it must be fixed before
2.6.18 is out. Attached is a patch.

Michal



             reply	other threads:[~2006-07-14  2:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-14  2:08 Michal Ludvig [this message]
2006-07-14  2:14 ` [CRYPTO] padlock: Fix alignment after aes_ctx rearrange Michal Ludvig
2006-07-15  1:25 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44B6FC90.2060501@logix.cz \
    --to=michal@logix.cz \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.