All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
	guichaz@yahoo.fr, netdev@vger.kernel.org
Subject: Re: [PATCH] clear skb cb on IP input
Date: Sat, 15 Jul 2006 08:50:58 -0700	[thread overview]
Message-ID: <44B90EE2.1080808@osdl.org> (raw)
In-Reply-To: <E1G1kCA-000533-00@gondolin.me.apana.org.au>

Herbert Xu wrote:
> David Miller <davem@davemloft.net> wrote:
>   
>> Thank goodness this thing is only 3-words in size, this is going to
>> run on every single IPv4 packet received by the system. :-/
>>     
>
> At least this lets us get rid of a few other memsets :)
>
> [IPV4]: Get rid of redundant IPCB->opts initialisation
>
> Now that we always zero the IPCB->opts in ip_rcv, it is no longer
> necessary to do so before calling netif_rx for tunneled packets.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Cheers
>   

Since skb->cb is aligned, we could optimize the initialization
slightly by just using:
    *(unsigned long *)skb->cb = 0;


  reply	other threads:[~2006-07-15 15:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-14 14:34 Netem does not work with loopback Guillaume Chazarain
2006-07-14 15:38 ` Stephen Hemminger
2006-07-14 17:04   ` Guillaume Chazarain
2006-07-14 18:39     ` Stephen Hemminger
2006-07-14 18:49       ` Guillaume Chazarain
2006-07-14 18:56         ` [PATCH] clear skb cb on IP input Stephen Hemminger
2006-07-14 21:48           ` David Miller
2006-07-15 13:28             ` Herbert Xu
2006-07-15 15:50               ` Stephen Hemminger [this message]
2006-07-16  1:15                 ` David Miller
2006-07-16  1:12               ` David Miller
2006-07-16 11:20                 ` chas williams - CONTRACTOR
2006-07-17  2:02                   ` David Miller
2006-07-18 18:19                   ` Guillaume Chazarain
2006-07-18 19:43                     ` Herbert Xu
2006-07-19 12:35                       ` Guillaume Chazarain
2006-07-25  6:45                         ` David Miller
2006-07-16 22:03                 ` Herbert Xu
2006-07-17  1:18                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44B90EE2.1080808@osdl.org \
    --to=shemminger@osdl.org \
    --cc=davem@davemloft.net \
    --cc=guichaz@yahoo.fr \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.