All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Boot <bootc@bootc.net>
To: Chris Boot <bootc@bootc.net>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, Jim Cromie <jim.cromie@gmail.com>,
	Adrian Bunk <bunk@stusta.de>
Subject: Re: [PATCH] scx200_gpio export cleanups
Date: Sat, 15 Jul 2006 19:50:35 +0100	[thread overview]
Message-ID: <44B938FB.3010004@bootc.net> (raw)
In-Reply-To: <44B936C8.9070907@bootc.net>

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

Chris Boot wrote:
> Use EXPORT_SYMBOL_GPL for new symbols, and declare the struct in the 
> header file for access by other modules.
> 
> Signed-off-by: Chris Boot <bootc@bootc.net>

Corrupted patch... Attached.

-- 
Chris Boot
bootc@bootc.net
http://www.bootc.net/

[-- Attachment #2: scx200-export-cleanups.patch --]
[-- Type: text/x-patch, Size: 847 bytes --]

diff --git a/drivers/char/scx200_gpio.c b/drivers/char/scx200_gpio.c
index b956c7b..8ecef2e 100644
--- a/drivers/char/scx200_gpio.c
+++ b/drivers/char/scx200_gpio.c
@@ -44,7 +44,7 @@ struct nsc_gpio_ops scx200_gpio_ops = {
 	.gpio_change	= scx200_gpio_change,
 	.gpio_current	= scx200_gpio_current
 };
-EXPORT_SYMBOL(scx200_gpio_ops);
+EXPORT_SYMBOL_GPL(scx200_gpio_ops);
 
 static int scx200_gpio_open(struct inode *inode, struct file *file)
 {
diff --git a/include/linux/scx200_gpio.h b/include/linux/scx200_gpio.h
index 90dd069..1a82d30 100644
--- a/include/linux/scx200_gpio.h
+++ b/include/linux/scx200_gpio.h
@@ -4,6 +4,7 @@ u32 scx200_gpio_configure(unsigned index
 
 extern unsigned scx200_gpio_base;
 extern long scx200_gpio_shadow[2];
+extern struct nsc_gpio_ops scx200_gpio_ops;
 
 #define scx200_gpio_present() (scx200_gpio_base!=0)
 

      reply	other threads:[~2006-07-15 18:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-15 18:41 [PATCH] scx200_gpio export cleanups Chris Boot
2006-07-15 18:50 ` Chris Boot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44B938FB.3010004@bootc.net \
    --to=bootc@bootc.net \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=jim.cromie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.