From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Mahoney Subject: Re: [PATCH] reiserfs: fix handling of device names with /'s in them Date: Mon, 17 Jul 2006 10:55:11 -0400 Message-ID: <44BBA4CF.8020901@suse.com> References: <6xQ4C-6NB-43@gated-at.bofh.it> <6xQea-6ZX-13@gated-at.bofh.it> <44B7D97B.20708@suse.com> <44B9E6D5.2040704@namesys.com> <44BA61A2.5090404@suse.com> <44BA8214.7040005@namesys.com> <44BABB14.6070906@suse.com> <44BAE619.9010307@namesys.com> <44BAECE2.8070301@suse.com> <44BAFDC3.7020301@namesys.com> <44BB0146.7080702@suse.com> <44BB3C42.1060309@namesys.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: list-help: list-unsubscribe: list-post: Errors-To: flx@namesys.com In-Reply-To: <44BB3C42.1060309@namesys.com> List-Id: Content-Type: text/plain; charset="us-ascii" To: Hans Reiser Cc: 7eggert@gmx.de, Eric Dumazet , ReiserFS List , Linux Kernel Mailing List , Andrew Morton -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hans Reiser wrote: > I don't understand your patch and cannot support it as it is written. > Perhaps you can call me and explain it on the phone. I seriously can't tell if you're deliberately trying to be difficult or not. It's a simple "replace / with ! before sending the name to procfs." Reiserfs requests that a procfs directory called /proc/fs/reiserfs/ be created. Some block devices contain slashes, so with cciss/c123 it attempts to create a directory called /proc/fs/reiserfs/cciss/c123, but cciss/ doesn't exist, shouldn't, and never will. In order to create a single path component, "cciss/c123" becomes "cciss!c123." This is consistent with how sysfs does it now. For a real example, change the "-" in device mapper block names to "/" and see what happens. Regardless, it's already been checked into mainline as change 6fbe82a952790c634ea6035c223a01a81377daf1. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFEu6TPLPWxlyuTD7IRAvFTAJ9MYmmhSljmJTYFFlQvwS1G5AWdWQCglN0u FCxA4sTIi/O5KRsZ38vzT1c= =M7gO -----END PGP SIGNATURE-----