From: Paul Clements <paul.clements@steeleye.com>
To: Michal Feix <michal@feix.cz>, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nbd: Check magic before doing anything else
Date: Mon, 17 Jul 2006 11:30:48 -0400 [thread overview]
Message-ID: <44BBAD28.6040701@steeleye.com> (raw)
In-Reply-To: <44BA39E5.7060002@feix.cz>
Michal Feix wrote:
> We should check magic sequence in reply packet before trying to find
> request with it's request handle. This also solves the problem with
> "Unexpected reply" message beeing logged, when packet with invalid magic
> is received.
Right. Again, we can't return NULL after pulling the request off the
queue, so we better do this check first.
Andrew, these two look good to me.
Thanks,
Paul
prev parent reply other threads:[~2006-07-17 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-16 13:06 [PATCH] nbd: Check magic before doing anything else Michal Feix
2006-07-17 15:30 ` Paul Clements [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44BBAD28.6040701@steeleye.com \
--to=paul.clements@steeleye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal@feix.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.