All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan O'Hara <rohara@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/group/daemon app.c
Date: Mon, 17 Jul 2006 12:08:28 -0500	[thread overview]
Message-ID: <44BBC40C.9010500@redhat.com> (raw)
In-Reply-To: <44B9EFF9.2070504@ubuntu.com>


I've checked-in a fix. I hit this problem this morning as well.

Thanks.

Ryan


Fabio Massimo Di Nitto wrote:
> teigland at sourceware.org wrote:
> 
>> Patches:
>> http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/daemon/app.c.diff?cvsroot=cluster&r1=1.34&r2=1.35
>>
>> --- cluster/group/daemon/app.c	2006/06/28 22:16:36	1.34
>> +++ cluster/group/daemon/app.c	2006/07/14 20:45:27	1.35
>> @@ -1079,11 +1079,9 @@
>>  {
>>  	node_t *node;
>>  
>> -	if (!event_state_starting(a)) {
>> -		log_error(a->g, "mark_node_started: event not starting %d "
>> +	if (!event_state_starting(a))
>> +		log_debug(a->g, "mark_node_started: event not starting %d "
>>  			  "from %d", a->current_event->state, nodeid);
>> -		return -1;
>> -	}
> 
> Hi,
> 
> This commit fails to build. I am not sure if you want log_debug or log_error
> there, but in case of log_debug it's enough to remove "a->g,".
> 
> Thanks
> Fabio
> 



  reply	other threads:[~2006-07-17 17:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-14 20:45 [Cluster-devel] cluster/group/daemon app.c teigland
2006-07-16  7:51 ` Fabio Massimo Di Nitto
2006-07-17 17:08   ` Ryan O'Hara [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-10-16 15:52 teigland
2006-10-12 14:25 teigland
2006-09-15 20:07 teigland
2006-09-14 20:56 teigland
2006-08-31 18:20 teigland
2006-08-22 14:36 teigland
2006-08-14 21:01 teigland
2006-08-02 20:30 teigland
2006-07-19 19:45 teigland
2006-07-17 18:22 teigland
2006-07-17 17:06 rohara
2006-06-22 21:12 teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44BBC40C.9010500@redhat.com \
    --to=rohara@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.