All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [usb] call destroy for usb devices upon removal from guest
Date: Tue, 18 Jul 2006 23:46:28 +0200	[thread overview]
Message-ID: <44BD56B4.6010004@bellard.org> (raw)
In-Reply-To: <1153125312.4812.7.camel@vaio>

Lonnie Mendez wrote:
> lo list.  I have found the old diff to be incorrect on many levels.  New
> diff has additionally cleanup code for the linux redirector.  Please see
> the attached patch for solution.

Forget my last comment - I understand the problem now. I think it was a 
bad idea to use 'usb_reset' to destroy the usb device. Ideally a 
specific method should be added because it has no relation with the USB 
protocol (it is used to clear resources and it is perfectly possible 
that a given device can be inserted, removed and inserted again without 
having been destroyed). Another point is that the unused message 
'USB_DESTROY' should be... destroyed.

Regards,

Fabrice.

  parent reply	other threads:[~2006-07-18 22:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-17  8:35 [Qemu-devel] [usb] call destroy for usb devices upon removal from guest Lonnie Mendez
2006-07-18 21:36 ` Fabrice Bellard
2006-07-18 21:46 ` Fabrice Bellard [this message]
2006-07-19  3:12   ` Lonnie Mendez
  -- strict thread matches above, loose matches on Subject: below --
2006-05-26 22:36 Lonnie Mendez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44BD56B4.6010004@bellard.org \
    --to=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.