From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, lkml@rtr.ca, axboe@suse.de,
forrest.zhao@intel.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 10/12] libata: implement standard powersave methods
Date: Wed, 19 Jul 2006 15:50:12 -0400 [thread overview]
Message-ID: <44BE8CF4.2010006@pobox.com> (raw)
In-Reply-To: <11531191524049-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> Implement helpers to build SATA ->set_powersave() and HIPS timer, and
> use them to implement sata_std_set_powersave() and
> sata_std_hips_timer_fn() for standard SATA link powersave using
> SControl register.
>
> Depending on controller capability, the following modes are supported.
>
> none: no powersave
> HIPS: host-initiated partial/slumber (both or either one)
> DIPS: device-initiated partial/slumber (both or either one)
> static: link off by writing 0x4 to DET
> HIPS/static: HIPS + static
> DIPS/static; DIPS + static
>
> Timeouts for HIPS can be modified using module parameters -
> libata.partial_timeout and libata.slumber_timeout. Setting timeout to
> zero disables the powersave mode.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> ---
>
> drivers/scsi/libata-core.c | 280 ++++++++++++++++++++++++++++++++++++++++++++
> include/linux/libata.h | 10 ++
> 2 files changed, 290 insertions(+), 0 deletions(-)
>
> e19c560ab7e8fa9b20ed5ec3233fb75e0daceb63
> diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
> index 1658cd1..9890387 100644
> --- a/drivers/scsi/libata-core.c
> +++ b/drivers/scsi/libata-core.c
> @@ -71,6 +71,7 @@ static unsigned int ata_dev_set_xfermode
> static void ata_dev_xfermask(struct ata_device *dev);
>
> static int ata_param_set_powersave(const char *val, struct kernel_param *kp);
> +static int ata_param_set_hips_timeout(const char *val, struct kernel_param *kp);
>
> static DEFINE_MUTEX(ata_all_ports_mutex);
> static LIST_HEAD(ata_all_ports);
> @@ -102,6 +103,18 @@ module_param_call(powersave, ata_param_s
> MODULE_PARM_DESC(powersave, "Powersave mode (0=none, 1=HIPS, 2=DIPS, "
> "3=static, 4=HIPS/static, 5=DIPS/static)");
>
> +static unsigned long libata_partial_timeout = 100;
> +module_param_call(partial_timeout, ata_param_set_hips_timeout, param_get_ulong,
> + &libata_partial_timeout, 0644);
> +MODULE_PARM_DESC(hips_timeout, "Host-initiated partial powersave timeout "
> + "(milliseconds, default 100, 0 to disable)");
> +
> +static unsigned long libata_slumber_timeout = 3000;
> +module_param_call(slumber_timeout, ata_param_set_hips_timeout, param_get_ulong,
> + &libata_slumber_timeout, 0644);
> +MODULE_PARM_DESC(slumber_timeout, "Host-initiated slumber powersave timeout "
> + "(milliseconds, default 3000, 0 to disable)");
> +
Should be a per-controller variable, not a global libata module parm.
So NAK on interface, ACK on implementation behind the interface.
Jeff
next prev parent reply other threads:[~2006-07-19 19:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-17 6:52 [PATCHSET] libata: implement runtime link powersave Tejun Heo
2006-07-17 6:52 ` [PATCH 04/12] libata: implement ata_all_ports list Tejun Heo
2006-07-19 19:34 ` Jeff Garzik
2006-07-17 6:52 ` [PATCH 03/12] libata: add more SATA specific constants and macros to ata.h Tejun Heo
2006-07-19 19:32 ` Jeff Garzik
2006-07-17 6:52 ` [PATCH 02/12] libata: add ata_id_has_sata() and use it in ata_id_has_ncq() Tejun Heo
2006-07-17 6:52 ` [PATCH 01/12] libata: add msec_to_jiffies() Tejun Heo
2006-07-17 6:52 ` [PATCH 10/12] libata: implement standard powersave methods Tejun Heo
2006-07-19 19:50 ` Jeff Garzik [this message]
2006-07-17 6:52 ` [PATCH 11/12] ahci: implement link powersave Tejun Heo
2006-07-19 19:51 ` Jeff Garzik
2006-07-17 6:52 ` [PATCH 05/12] libata: make counting functions global Tejun Heo
2006-07-17 6:52 ` [PATCH 09/12] libata: implement powersave timer Tejun Heo
2006-07-19 19:48 ` Jeff Garzik
2006-07-19 20:22 ` Jens Axboe
2006-07-24 7:27 ` Tejun Heo
2006-07-25 8:01 ` Jens Axboe
2006-07-17 6:52 ` [PATCH 08/12] libata: implement interface power management infrastructure Tejun Heo
2006-07-19 19:45 ` Jeff Garzik
2006-07-24 8:02 ` Tejun Heo
2006-07-17 6:52 ` [PATCH 06/12] libata: add ata_port_nr_ready() Tejun Heo
2006-07-17 6:52 ` [PATCH 07/12] libata: implement sata_update_scontrol() Tejun Heo
2006-07-19 19:35 ` Jeff Garzik
2006-07-17 6:52 ` [PATCH 12/12] sata_sil24: implement link powersave Tejun Heo
2006-07-19 19:38 ` [PATCHSET] libata: implement runtime " Jeff Garzik
2006-07-24 7:33 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44BE8CF4.2010006@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=forrest.zhao@intel.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=lkml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.