All of lore.kernel.org
 help / color / mirror / Atom feed
From: Auke Kok <auke-jan.h.kok@intel.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org,
	xen-devel@lists.xensource.com,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: e1000: Problem with "disable CRC stripping workaround" patch
Date: Thu, 20 Jul 2006 09:42:48 -0700	[thread overview]
Message-ID: <44BFB288.5000105@intel.com> (raw)
In-Reply-To: <1153411868.2758.34.camel@localhost.localdomain>

Mark McLoughlin wrote:
> Hi Jesse,
> 	I just came across this:
> 
>   http://www.mail-archive.com/netdev@vger.kernel.org/msg14547.html
> 
> 	I'm seeing a problem with this currently under Xen's bridging
> configuration.


 > 	One option is to fix this specific problem is to subtract the CRC
 > length from skb->len in e1000, another is to raise the MTU on the
 > receive side of Xen's loopback interface. I've attached a patch for the
 > latter, but I've no real opinion on which is more correct.

We were sort of expecting this and sent the following patch upstream already - 
it's already queued for 2.6.18-rc3:

http://kernel.org/git/?p=linux/kernel/git/jgarzik/netdev-2.6.git;a=commitdiff_plain;h=f235a2abb27b9396d2108dd2987fb8262cb508a3;hp=d3d9e484b2ca502c87156b69fa6b8f8fd5fa18a0

Please give it a try and let us know if it fixes the issue for you, it should 
be much better than patching xen's code.

Cheers,

Auke

  reply	other threads:[~2006-07-20 16:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-20 16:11 e1000: Problem with "disable CRC stripping workaround" patch Mark McLoughlin
2006-07-20 16:11 ` Mark McLoughlin
2006-07-20 16:42 ` Auke Kok [this message]
2006-07-20 20:04   ` Herbert Xu
2006-07-20 20:04     ` Herbert Xu
2006-07-21  8:51   ` Mark McLoughlin
2006-07-21  8:51     ` Mark McLoughlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44BFB288.5000105@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markmc@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.