Re: [PATCH] BUG: libiptc chain references bug

[Patrick McHardy <kaber@trash.net>]

Jesper Dangaard Brouer wrote:
> 
> On Sun, 16 Jul 2006, Pablo Neira Ayuso wrote:
> 
>> I don't like too much the is-the-rule-in-list checking in
>> delete_entry, please, could you tell me what you think about the patch
>> attached? I think it's cleaner. Thanks.
> 
> 
> First of all, (no offence) your patch will not work, as it does not
> catch all control-flow cases. That is, if no match was found your patch
> does not decrement the refcount. Hint, look at the places free(r) is
> called.
> 
> I have attached a patch, that does catch all cases.  This is achived by
> adding a else statement to the if statement where iptcc_map_target is
> called.
> 
> I did consider, your strategy, but the reason I decided not to, was that
> I though it was cleaner to always call "iptcc_delete_rule" when we want
> to delete a rule, instead of free'ing it manually.
> 
> Well, I think Patrick should make the decision. As long as we fix the
> bug, I don't care which patch goes in.


I like the second patch better than the first one, so I've applied
this one. Thanks Jesper.