From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Jeremy Higdon <jeremy@sgi.com>
Cc: Jes Sorensen <jes@sgi.com>, Brent Casavant <bcasavan@sgi.com>,
jpk@sgi.com, Andrew Morton <akpm@osdl.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux IDE <linux-ide@vger.kernel.org>
Subject: Re: [Fwd: - ide-remove-dma_base2-field-form-ide_hwif_t.patch removed from -mm tree]
Date: Wed, 26 Jul 2006 23:23:47 +0400 [thread overview]
Message-ID: <44C7C143.5050201@ru.mvista.com> (raw)
In-Reply-To: <20060724225703.GD776006@sgi.com>
Hello.
Jeremy Higdon wrote:
>> Alan and Andrew wanted me to coordinate the change with SGI before
>>recasting this patch because the sgiioc4.c is the only real user of the
>>'dma_base2' field which the IDE maintaner wanted me to remove. The use of
>>this field in this driver doesn't seem necessary or even well grounded --
>>hwif_data seem to fit the task better... Will you ACK this change?
> This patch won't apply with the line wrapping in the email. Can you please
> resend? You can turn off the "format=flowed" tag in your mailer or send as
> an attachment.
Done, after being recast. Please ACK or NAK.
> The field is necessary for proper operation of the driver.
My point is that there's better choice -- with hwif_data we can get rid of
the typecasts. dma_base2 should just go away.
> jeremy
WBR, Sergei
next prev parent reply other threads:[~2006-07-26 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 20:25 [Fwd: - ide-remove-dma_base2-field-form-ide_hwif_t.patch removed from -mm tree] Sergei Shtylyov
2006-07-24 22:57 ` Jeremy Higdon
2006-07-26 19:21 ` [PATCH] remove dma_base2 field form ide_hwif_t Sergei Shtylyov
2006-07-26 19:23 ` Sergei Shtylyov [this message]
2006-07-26 19:29 ` [Fwd: - ide-remove-dma_base2-field-form-ide_hwif_t.patch removed from -mm tree] Brent Casavant
2006-07-25 18:25 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44C7C143.5050201@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bcasavan@sgi.com \
--cc=jeremy@sgi.com \
--cc=jes@sgi.com \
--cc=jpk@sgi.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.