From: liyu <liyu@ccoss.com.cn>
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] usbhid: Driver for microsoft natural ergonomic keyboard 4000
Date: Thu, 27 Jul 2006 08:47:58 +0800 [thread overview]
Message-ID: <44C80D3E.5090706@ccoss.com.cn> (raw)
In-Reply-To: <20060726161232.GC28284@filer.fsl.cs.sunysb.edu>
Josef Sipek wrote:
> +#define map_key(c) \
> + do { \
> + usage->code = c; \
> + usage->type = EV_KEY; \
> + set_bit(c,input->keybit); \
> + } while (0)
>
> I'm not quite sure where usage is coming from. Some magical global variable?
> Eeek.
>
> Josef "Jeff" Sipek.
>
>
These macroes like map_key() only use in nek4k_setup_usage() and
ne4k_clear_usage(), so the
variable "usage" is coming from their parameter.
PS: these macroes are modifed from hid-input.c
next prev parent reply other threads:[~2006-07-27 0:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-26 10:42 [PATCH 1/3] usbhid: Driver for microsoft natural ergonomic keyboard 4000 liyu
2006-07-26 16:12 ` Josef Sipek
2006-07-27 0:47 ` liyu [this message]
2006-07-27 1:46 ` Josef Sipek
2006-07-28 13:54 ` Pavel Machek
2006-07-31 0:48 ` liyu
2006-07-31 1:30 ` Dmitry Torokhov
2006-07-31 5:24 ` liyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44C80D3E.5090706@ccoss.com.cn \
--to=liyu@ccoss.com.cn \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.