Re: aggg Re: libnfnetlink_conntrack encapsulation issues

[Patrick McHardy <kaber@trash.net>]

Amin Azez wrote:
> Not only is linux_nfnetlink_conntrack.h from SVN and not any kernel, it
> even ignores the kernel config so such ifdef's as:
> 
> enum ctattr_type {
>         CTA_UNSPEC,
>         CTA_TUPLE_ORIG,
>         CTA_TUPLE_REPLY,
>         CTA_STATUS,
>         CTA_PROTOINFO,
>         CTA_HELP,
>         CTA_NAT_SRC,
> #define CTA_NAT       CTA_NAT_SRC     /* backwards compatibility */
>         CTA_TIMEOUT,
>         CTA_MARK,
>         CTA_COUNTERS_ORIG,
>         CTA_COUNTERS_REPLY,
>         CTA_USE,
>         CTA_ID,
>         CTA_NAT_DST,
> #if defined(CONFIG_IP_NF_MATCH_LAYER7) ||
> defined(CONFIG_IP_NF_MATCH_LAYER7_MODULE)
>         CTA_L7,
> #endif /* LAYER7 */
> #ifdef CONFIG_IP_NF_CT_LINKLAYER
>         CTA_LINKLAYER,
> #endif /* LINKLAYER */
> ...
> ...
> ...

WTF is this? Its not from SVN, it appears the layer7 match does some
bad hacks here. It looks like a really dumb idea, this will break
once we add new attributes. Not sure why a match would need ctnetlink
attributes.