From: Martin Peschke <mp3@de.ibm.com>
To: Paul Jackson <pj@sgi.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch 1/2] CPU hotplug compatible alloc_percpu
Date: Fri, 28 Jul 2006 08:15:20 +0200 [thread overview]
Message-ID: <44C9AB78.8060104@de.ibm.com> (raw)
In-Reply-To: <20060727091843.c2192bbc.pj@sgi.com>
Paul Jackson wrote:
> Martin wrote:
>> +static inline int percpu_populate_mask(void *__pdata, size_t size, gfp_t gfp,
>> + int cpu)
>> +{
>
> It seems odd to me that this signature of percpu_populate_mask()
> has its last argument 'int cpu' for the !CONFIG_SMP case, but
> the SMP signatures have 'cpumask_t mask'.
>
> Shouldn't this function signature be the same for all CONFIG's?
Looks like a mistake. Luckily, it won't cause any harm, though.
I will send a patch.
Thank you for reviewing.
Martin
prev parent reply other threads:[~2006-07-28 6:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 17:16 [Patch 1/2] CPU hotplug compatible alloc_percpu Martin Peschke
2006-07-26 6:02 ` Andrew Morton
2006-07-28 6:20 ` Martin Peschke
2006-07-27 16:18 ` Paul Jackson
2006-07-28 6:15 ` Martin Peschke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44C9AB78.8060104@de.ibm.com \
--to=mp3@de.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.