[lm-sensors] Patch to fully support W81791D

[lm-sensors] Patch to fully support W81791D

[Charles Spirakis]

Sven --

I'm a little confused. There is a patch already going into the 2.6
tree to include 83791d support (see
http://lists.lm-sensors.org/pipermail/lm-sensors/2006-June/016638.html).

Looking at this patch you are touching the w83781d driver and you
mention the 2.1.18 kernel. Is this meant for an older kernel? Was this
meant for the 2.6 kernel? And if it is meant for the 2.6 kernel, does
it do something more or better than the one listed in the url above?

-- charles


On 7/10/06, Sven Anders <anders at anduras.de> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
> Hello!
>
> I've attached a patch to fully support the W81791D chip, which is part of the
> coming kernel 2.1.18.
>
> Partial support was alredy implemented, but it was missing IN9/FAN4/FAN5 output.
>
> Please add it to the SVN.
>
> Thanks,
>  Regards
>    Sven
>
> - --
>  Sven Anders <anders at anduras.de>                 () Ascii Ribbon Campaign
>                                                  /\ Support plain text e-mail
>  ANDURAS service solutions AG
>  Innstra?e 71 - 94036 Passau - Germany
>  Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55
>
> Rechtsform: Aktiengesellschaft - Sitz: Passau - Amtsgericht Passau HRB 6032
> Mitglieder des Vorstands: Sven Anders, Marcus Junker, Michael Sch?n
> Vorsitzender des Aufsichtsrats: Dipl. Kfm. Thomas Tr?ger
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.2.1 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFEsjPI5lKZ7Feg4EcRAuCfAJ4py+TYmbnRSzQhOW8g7mls2juCUACfQ+Dg
> 4Wc9L9KsPo1BvYB8VNaWzws> vbb
> -----END PGP SIGNATURE-----
>
>
>

[lm-sensors] Patch to fully support W81791D

[Sven Anders]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> Sven --
> 
> I'm a little confused. There is a patch already going into the 2.6
> tree to include 83791d support (see
> http://lists.lm-sensors.org/pipermail/lm-sensors/2006-June/016638.html).
> 
> Looking at this patch you are touching the w83781d driver and you
> mention the 2.1.18 kernel. Is this meant for an older kernel? Was this
> meant for the 2.6 kernel? And if it is meant for the 2.6 kernel, does
> it do something more or better than the one listed in the url above?

Hello,
this must be a misunderstanding. This patch is for the lm_sensors Package,
not for the kernel. It adds the output for the additional sensors, that
were missing in the "sensors" program.

I know that the kernel driver will be included in the next stable kernel.
I only sent the sensors-patch to keep you informed.
(A patch for the kernel-driver will follow... ;-))

Regards
 Sven Anders

- --
 Sven Anders <anders at anduras.de>                 () Ascii Ribbon Campaign
                                                 /\ Support plain text e-mail
 ANDURAS service solutions AG
 Innstra?e 71 - 94036 Passau - Germany
 Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEsrkh5lKZ7Feg4EcRAikPAKCW6lDNbRF+utIIgwOPscNNnYhdLQCdHv0q
eC6dbekAhtlWw4TB7fuHyD8÷nC
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: anders.vcf
Type: text/x-vcard
Size: 339 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060710/278c172e/attachment.vcf 

[lm-sensors] Patch to fully support W81791D

[Charles Spirakis]

OK. Thanks.

-- charles


On 7/10/06, Sven Anders <anders at anduras.de> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> > Sven --
> >
> > I'm a little confused. There is a patch already going into the 2.6
> > tree to include 83791d support (see
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2006-June/016638.html).
> >
> > Looking at this patch you are touching the w83781d driver and you
> > mention the 2.1.18 kernel. Is this meant for an older kernel? Was this
> > meant for the 2.6 kernel? And if it is meant for the 2.6 kernel, does
> > it do something more or better than the one listed in the url above?
>
> Hello,
> this must be a misunderstanding. This patch is for the lm_sensors Package,
> not for the kernel. It adds the output for the additional sensors, that
> were missing in the "sensors" program.
>
> I know that the kernel driver will be included in the next stable kernel.
> I only sent the sensors-patch to keep you informed.
> (A patch for the kernel-driver will follow... ;-))
>
> Regards
>  Sven Anders
>
> - --
>  Sven Anders <anders at anduras.de>                 () Ascii Ribbon Campaign
>                                                  /\ Support plain text e-mail
>  ANDURAS service solutions AG
>  Innstra?e 71 - 94036 Passau - Germany
>  Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.2.1 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFEsrkh5lKZ7Feg4EcRAikPAKCW6lDNbRF+utIIgwOPscNNnYhdLQCdHv0q
> eC6dbekAhtlWw4TB7fuHyD8> ÷nC
> -----END PGP SIGNATURE-----
>
>
>

[lm-sensors] Patch to fully support W81791D

[Jean Delvare]

Charles, Sven,

> > I've attached a patch to fully support the W81791D chip, which is part of the
> > coming kernel 2.1.18.
> >
> > Partial support was alredy implemented, but it was missing IN9/FAN4/FAN5 output.
> >
> > Please add it to the SVN.

Where is this patch, please?

-- 
Jean Delvare

[lm-sensors] Patch to fully support W81791D

[Sven Anders]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jean Delvare schrieb:
> Charles, Sven,
> 
>>> I've attached a patch to fully support the W81791D chip, which is part of the
>>> coming kernel 2.1.18.
>>>
>>> Partial support was alredy implemented, but it was missing IN9/FAN4/FAN5 output.
>>>
>>> Please add it to the SVN.
> 
> Where is this patch, please?

It was attatched - I checked it...

But in case, something went wrong - here it comes again...

Regards
 Sven

- --
 Sven Anders <anders at anduras.de>                 () Ascii Ribbon Campaign
                                                 /\ Support plain text e-mail
 ANDURAS service solutions AG
 Innstra?e 71 - 94036 Passau - Germany
 Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55

Rechtsform: Aktiengesellschaft - Sitz: Passau - Amtsgericht Passau HRB 6032
Mitglieder des Vorstands: Sven Anders, Marcus Junker, Michael Sch?n
Vorsitzender des Aufsichtsrats: Dipl. Kfm. Thomas Tr?ger
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEyjSN5lKZ7Feg4EcRAvGBAJ48YIlcUulQ8UdJF7bRBDYYmzLbvACeP7rV
xCtQ0JdQ095lUX4nyzS6tEg=HDJJ
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lm-sensors-w83791d.patch
Type: text/x-diff
Size: 5344 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060728/266ddb5d/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: anders.vcf
Type: text/x-vcard
Size: 339 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060728/266ddb5d/attachment-0001.vcf 

[lm-sensors] Patch to fully support W81791D

[Jean Delvare]

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Jean Delvare schrieb:
> > Charles, Sven,
> > 
> >>> I've attached a patch to fully support the W81791D chip, which is part of the
> >>> coming kernel 2.1.18.
> >>>
> >>> Partial support was alredy implemented, but it was missing IN9/FAN4/FAN5 output.
> >>>
> >>> Please add it to the SVN.
> > 
> > Where is this patch, please?
> 
> It was attatched - I checked it...

I guess you had only sent it to Charles, who has no write access to the
repository. At least I did not receive your original post and I can't
see it in the mailing list archive either.

> But in case, something went wrong - here it comes again...

Great, thanks. Charles, can you please review and test the patch? Then
I'll apply it if it has no problem.

I'm very surprised that this support was missing since the W83791D
support was added. This means that parts of the drivers (w83781d in 2.4
and w83791d in 2.6) were never actually exercised.

Thanks,
-- 
Jean Delvare

[lm-sensors] Patch to fully support W81791D

[Charles Spirakis]

I'll give it a try.

Sven and I were also talking about a patch to the w83791d driver to
fix some of the beep/realtime status bits as the documentation doesn't
seem to match the hardware. I'll try to get that to the lmsensors
mailing list over the weekend.

-- charles


On 7/28/06, Jean Delvare <khali at linux-fr.org> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Jean Delvare schrieb:
> > > Charles, Sven,
> > >
> > >>> I've attached a patch to fully support the W81791D chip, which is part of the
> > >>> coming kernel 2.1.18.
> > >>>
> > >>> Partial support was alredy implemented, but it was missing IN9/FAN4/FAN5 output.
> > >>>
> > >>> Please add it to the SVN.
> > >
> > > Where is this patch, please?
> >
> > It was attatched - I checked it...
>
> I guess you had only sent it to Charles, who has no write access to the
> repository. At least I did not receive your original post and I can't
> see it in the mailing list archive either.
>
> > But in case, something went wrong - here it comes again...
>
> Great, thanks. Charles, can you please review and test the patch? Then
> I'll apply it if it has no problem.
>
> I'm very surprised that this support was missing since the W83791D
> support was added. This means that parts of the drivers (w83781d in 2.4
> and w83791d in 2.6) were never actually exercised.
>
> Thanks,
> --
> Jean Delvare
>

[lm-sensors] Patch to fully support W81791D

[Charles Spirakis]

Jean --

I can't speak for the 2.4 driver, but the testing that I did for the
2.6 driver was based on the values in /sys. The biggest changes Sven
found were that the user-mode sensors tool wasn't showing all the
values from the w83791d that it could. Sven provided a patch for this
which will be submitted in a separate email.

As for driver bugs, Sven did find one of those too - the beep enable
and the realtime status bits don't completely match the documentation
and one of the beep enable bits needs to be swapped. A second patch
will be submitted for this.

-- charles


On 7/28/06, Charles Spirakis <bezaur at gmail.com> wrote:
> I'll give it a try.
>
> Sven and I were also talking about a patch to the w83791d driver to
> fix some of the beep/realtime status bits as the documentation doesn't
> seem to match the hardware. I'll try to get that to the lmsensors
> mailing list over the weekend.
>
> -- charles
>
>
> On 7/28/06, Jean Delvare <khali at linux-fr.org> wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Jean Delvare schrieb:
> > > > Charles, Sven,
> > > >
> > > >>> I've attached a patch to fully support the W81791D chip, which is part of the
> > > >>> coming kernel 2.1.18.
> > > >>>
> > > >>> Partial support was alredy implemented, but it was missing IN9/FAN4/FAN5 output.
> > > >>>
> > > >>> Please add it to the SVN.
> > > >
> > > > Where is this patch, please?
> > >
> > > It was attatched - I checked it...
> >
> > I guess you had only sent it to Charles, who has no write access to the
> > repository. At least I did not receive your original post and I can't
> > see it in the mailing list archive either.
> >
> > > But in case, something went wrong - here it comes again...
> >
> > Great, thanks. Charles, can you please review and test the patch? Then
> > I'll apply it if it has no problem.
> >
> > I'm very surprised that this support was missing since the W83791D
> > support was added. This means that parts of the drivers (w83781d in 2.4
> > and w83791d in 2.6) were never actually exercised.
> >
> > Thanks,
> > --
> > Jean Delvare
> >
>