From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [PATCH][RFC] open HVM backing storage with O_SYNC Date: Fri, 28 Jul 2006 16:21:29 -0400 Message-ID: <44CA71C9.1040408@redhat.com> References: <44C9B75B.7060809@redhat.com> <44CA4330.7010007@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <44CA4330.7010007@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Rik van Riel wrote: > Rik van Riel wrote: > >> Any comments on this patch? > > I got some comments from Alan, who would like to see this behaviour > tunable with hdparm from inside the guest. This requires larger > qemu changes though, to be specific an ->fsync callback into each > of the backing store drivers, so that is something for the qemu > mailing list. Considering the AIO-based development going on in the qemu community, I think we should stick with the O_SYNC band-aid. The idea Alan described would just be a fancier band-aid. > The current bottleneck seems to be that MAX_MULT_COUNT is only 16. Upon closer inspection of the code, this seems to not be the case for LBA48 transfers. -- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. Kernighan