From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zachary Amsden Subject: Re: [PATCH] turn off writable page tables Date: Fri, 28 Jul 2006 16:10:44 -0700 Message-ID: <44CA9974.9030804@vmware.com> References: <66edb0fb6e0664d309b10701168c495e@cl.cam.ac.uk> <44CA8369.9080200@vmware.com> <200607290105.46208.ak@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200607290105.46208.ak@suse.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andi Kleen Cc: virtualization@lists.osdl.org, xen-devel@lists.xensource.com, Andrew Theurer List-Id: xen-devel@lists.xenproject.org Andi Kleen wrote: > On Friday 28 July 2006 23:36, Zachary Amsden wrote: > >> For SMP, the enter / leave must happen under protection of the page table >> locks for page tables which are being modified. >> > > This should be in a comment in the code > Most definitely agreed! I think it deserves an entire paragraph explaining how to use it properly. But I wanted to get input from the Xen folks to see if this can be useful for them in some way first. Zach