All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] the scheduled removal of drivers/ieee1394/sbp2.c:force_inquiry_hack
Date: Sat, 29 Jul 2006 19:54:59 +0200	[thread overview]
Message-ID: <44CBA0F3.5020908@s5r6.in-berlin.de> (raw)
In-Reply-To: <20060729174828.GC26963@stusta.de>

Adrian Bunk wrote:
> This patch contains the scheduled removal of the force_inquiry_hack 
> module parameter.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

How the time flies. Thanks.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

> ---
> 
>  Documentation/feature-removal-schedule.txt |    9 ---------
>  drivers/ieee1394/sbp2.c                    |   10 ----------
>  2 files changed, 19 deletions(-)
> 
> --- linux-2.6.18-rc2-mm1-full/Documentation/feature-removal-schedule.txt.old	2006-07-27 20:36:51.000000000 +0200
> +++ linux-2.6.18-rc2-mm1-full/Documentation/feature-removal-schedule.txt	2006-07-27 20:37:00.000000000 +0200
> @@ -23,15 +23,6 @@
>  
>  ---------------------------
>  
> -What:	sbp2: module parameter "force_inquiry_hack"
> -When:	July 2006
> -Why:	Superceded by parameter "workarounds". Both parameters are meant to be
> -	used ad-hoc and for single devices only, i.e. not in modprobe.conf,
> -	therefore the impact of this feature replacement should be low.
> -Who:	Stefan Richter <stefanr@s5r6.in-berlin.de>
> -
> ----------------------------
> -
>  What:	Video4Linux API 1 ioctls and video_decoder.h from Video devices.
>  When:	July 2006
>  Why:	V4L1 AP1 was replaced by V4L2 API. during migration from 2.4 to 2.6
> --- linux-2.6.18-rc2-mm1-full/drivers/ieee1394/sbp2.c.old	2006-07-27 20:37:10.000000000 +0200
> +++ linux-2.6.18-rc2-mm1-full/drivers/ieee1394/sbp2.c	2006-07-27 20:37:23.000000000 +0200
> @@ -173,11 +173,6 @@
>  	", override internal blacklist = " __stringify(SBP2_WORKAROUND_OVERRIDE)
>  	", or a combination)");
>  
> -/* legacy parameter */
> -static int force_inquiry_hack;
> -module_param(force_inquiry_hack, int, 0644);
> -MODULE_PARM_DESC(force_inquiry_hack, "Deprecated, use 'workarounds'");
> -
>  /*
>   * Export information about protocols/devices supported by this driver.
>   */
> @@ -1554,11 +1549,6 @@
>  	}
>  
>  	workarounds = sbp2_default_workarounds;
> -	if (force_inquiry_hack) {
> -		SBP2_WARN("force_inquiry_hack is deprecated. "
> -			  "Use parameter 'workarounds' instead.");
> -		workarounds |= SBP2_WORKAROUND_INQUIRY_36;
> -	}
>  
>  	if (!(workarounds & SBP2_WORKAROUND_OVERRIDE))
>  		for (i = 0; i < ARRAY_SIZE(sbp2_workarounds_table); i++) {
> 


-- 
Stefan Richter
-=====-=-==- -=== ===-=
http://arcgraph.de/sr/

      reply	other threads:[~2006-07-29 17:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-29 17:48 [RFC: 2.6 patch] the scheduled removal of drivers/ieee1394/sbp2.c:force_inquiry_hack Adrian Bunk
2006-07-29 17:54 ` Stefan Richter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44CBA0F3.5020908@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.