From: Eric Sandeen <sandeen@sandeen.net>
To: Andi Kleen <ak@suse.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] kill leftover WANT_FUNCS macro indirection
Date: Sat, 29 Jul 2006 17:23:05 -0500 [thread overview]
Message-ID: <44CBDFC9.3040202@sandeen.net> (raw)
In-Reply-To: <p73k65w41je.fsf@verdi.suse.de>
Andi Kleen wrote:
> Eric Sandeen <sandeen@sandeen.net> writes:
>
>> This gets rid of some pointless macro defines... I had a version that
>> lower-cased it all too but Nathan liked this better, and he's the man!
>> :)
>
> Shouted function names is not exactly Linux code style at least.
>
> -Andi
>
well, *shrug* I have both versions, Nathan can take his pick :)
honestly, one-liner static inlines isn't exactly linux code style either, tho
the typechecking is nice.
I guess I shouldn't have said "Nathan liked this better" - I think he was being
pragmatic about the scope of the change.
-Eric
next prev parent reply other threads:[~2006-07-29 22:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-29 4:21 [PATCH] kill leftover WANT_FUNCS macro indirection Eric Sandeen
2006-07-29 20:08 ` Andi Kleen
2006-07-29 22:23 ` Eric Sandeen [this message]
2006-07-30 22:54 ` Nathan Scott
2006-07-30 23:17 ` David Chatterton
2006-07-31 0:54 ` Andi Kleen
2006-08-06 9:45 ` Martin Steigerwald
2006-09-20 4:14 ` linux-xfs
2006-09-20 11:41 ` David Chatterton
2006-09-20 13:33 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CBDFC9.3040202@sandeen.net \
--to=sandeen@sandeen.net \
--cc=ak@suse.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.