From: Eric Sandeen <sandeen@sandeen.net>
To: Nathan Scott <nathans@sgi.com>
Cc: dgc@sgi.com, xfs@oss.sgi.com
Subject: Re: [PATCH] kill no-op buf macros
Date: Sun, 30 Jul 2006 23:03:09 -0500 [thread overview]
Message-ID: <44CD80FD.5060101@sandeen.net> (raw)
In-Reply-To: <20060731090815.B2280998@wobbly.melbourne.sgi.com>
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
Nathan Scott wrote:
>> #define XFS_BUF_ISUNINITIAL(bp) (0)
>
> This can go, unwritten extents don't use this interface on Linux.
>
>> #define XFS_BUF_BP_ISMAPPED(bp) (1)
>
> *nod* - looks like it should go.
>
> (could you regen the patch with just these two for now? they are
> pretty much self-contained changes, and nice 'n small)
Ok, here it is, not so interesting :)
-Eric
[-- Attachment #2: kill-BUF_ISUNINITIAL_and_ISMAPPED --]
[-- Type: text/plain, Size: 1902 bytes --]
Remove a couple of unused BUF macros
Signed-Off-By: Eric Sandeen <sandeen@sandeen.net>
Index: xfs-linux/linux-2.4/xfs_buf.h
===================================================================
--- xfs-linux.orig/linux-2.4/xfs_buf.h
+++ xfs-linux/linux-2.4/xfs_buf.h
@@ -380,10 +380,6 @@ BUFFER_FNS(Delay, delay)
#define XFS_BUF_WRITE(bp) ((bp)->b_flags |= XBF_WRITE)
#define XFS_BUF_UNWRITE(bp) ((bp)->b_flags &= ~XBF_WRITE)
-#define XFS_BUF_ISUNINITIAL(bp) (0)
-
-#define XFS_BUF_BP_ISMAPPED(bp) (1)
-
#define XFS_BUF_DATAIO(bp) ((bp)->b_flags |= XBF_FS_DATAIOD)
#define XFS_BUF_UNDATAIO(bp) ((bp)->b_flags &= ~XBF_FS_DATAIOD)
Index: xfs-linux/linux-2.6/xfs_buf.h
===================================================================
--- xfs-linux.orig/linux-2.6/xfs_buf.h
+++ xfs-linux/linux-2.6/xfs_buf.h
@@ -296,10 +296,6 @@ extern void xfs_buf_trace(xfs_buf_t *, c
#define XFS_BUF_WRITE(bp) ((bp)->b_flags |= XBF_WRITE)
#define XFS_BUF_UNWRITE(bp) ((bp)->b_flags &= ~XBF_WRITE)
-#define XFS_BUF_ISUNINITIAL(bp) (0)
-
-#define XFS_BUF_BP_ISMAPPED(bp) (1)
-
#define XFS_BUF_IODONE_FUNC(bp) ((bp)->b_iodone)
#define XFS_BUF_SET_IODONE_FUNC(bp, func) ((bp)->b_iodone = (func))
#define XFS_BUF_CLR_IODONE_FUNC(bp) ((bp)->b_iodone = NULL)
Index: xfs-linux/xfs_buf_item.c
===================================================================
--- xfs-linux.orig/xfs_buf_item.c
+++ xfs-linux/xfs_buf_item.c
@@ -234,7 +234,6 @@ xfs_buf_item_format(
ASSERT((bip->bli_flags & XFS_BLI_LOGGED) ||
(bip->bli_flags & XFS_BLI_STALE));
bp = bip->bli_buf;
- ASSERT(XFS_BUF_BP_ISMAPPED(bp));
vecp = log_vector;
/*
@@ -901,7 +900,6 @@ xfs_buf_item_relse(
XFS_BUF_SET_FSPRIVATE(bp, bip->bli_item.li_bio_list);
if ((XFS_BUF_FSPRIVATE(bp, void *) == NULL) &&
(XFS_BUF_IODONE_FUNC(bp) != NULL)) {
- ASSERT((XFS_BUF_ISUNINITIAL(bp)) == 0);
XFS_BUF_CLR_IODONE_FUNC(bp);
}
next prev parent reply other threads:[~2006-07-31 4:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-30 3:41 [PATCH] kill no-op buf macros Eric Sandeen
2006-07-30 23:08 ` Nathan Scott
2006-07-31 0:25 ` Eric Sandeen
2006-07-31 4:03 ` Eric Sandeen [this message]
2006-08-09 1:24 ` David Chinner
2006-08-09 2:43 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CD80FD.5060101@sandeen.net \
--to=sandeen@sandeen.net \
--cc=dgc@sgi.com \
--cc=nathans@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.