All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Artem B. Bityutskiy" <dedekind@yandex.ru>
To: Josh Boyer <jwboyer@gmail.com>
Cc: linux-mtd@lists.infradead.org, haver@vnet.ibm.com,
	"Jörn Engel" <joern@wohnheim.fh-wedel.de>,
	"Marteo Tim" <tim.marteo@gmail.com>
Subject: Re: how to use jff2 on UBI layer?
Date: Mon, 31 Jul 2006 11:21:33 +0400	[thread overview]
Message-ID: <44CDAF7D.4040300@yandex.ru> (raw)
In-Reply-To: <625fc13d0607301228y2bfd2c62q462c508d57a32043@mail.gmail.com>

Josh Boyer wrote:
> For what it's worth, I personally prefer the gluebi approach.  Or at
> least it's design.  I don't see why UBI cannot add_mtd_device for
> every volume that is found within the overall MTD given to it.

Just because it's strange from the design POV. UBI != MTD device 
semantically => any attempt to access UBI as MTD device is a dirty hack.

> It seems somewhat superfluous to add a generalized I/O layer to jffs2.
> It just doesn't sit right with me.

---------
I have nothing against gluebi as soon as:

1. It works. And AFAICS, we cannot make it all right *for months*.
2. It does not include a lot of stuff like:
	if (jffs2_is_ubi(c)) {doh()}
scattered across JFFS2. Instead, JFFS2 must have zero changes in case of 
gluebi.

Otherwise, gluebi makes no sense, IMO.

---------

"Something superfluous" are just some subjective words. The objective 
things are

1. JFFS2 just works with my patch over UBI: mount -t jffs2 ubi0 
/mnt/jffs2 - and you're happy. No need to create strange "fake" MTD devices.

2. There is no half-sane (from MTD's POW!) mtd->put_block() addition in 
my patch.

3. After all - I see nothing bad in this "superfluous" thing. It just 
adds better modularization. Moreover, now I can remove crap like

#ifdef __ECOS
mtd->point()
#endif

as well as eCos erasure.

just because I can implement eCos I/O in io.c.


-- 
Best Regards,
Artem B. Bityutskiy,
St.-Petersburg, Russia.

  reply	other threads:[~2006-07-31  7:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-10  2:50 how to use jff2 on UBI layer? Marteo Tim
2006-07-10 13:01 ` Frank Haverkamp
2006-07-12  2:21   ` Tim Marteo
2006-07-20  2:42   ` Kyungmin Park
2006-07-20  9:45     ` Jörn Engel
2006-07-21  6:42       ` Frank Haverkamp
2006-07-21  7:59         ` Jörn Engel
2006-07-24 10:46       ` Artem B. Bityutskiy
2006-07-24 11:40         ` Jörn Engel
2006-07-26 16:52           ` Artem B. Bityutskiy
2006-07-27 12:54           ` Artem B. Bityutskiy
2006-07-30 19:28             ` Josh Boyer
2006-07-31  7:21               ` Artem B. Bityutskiy [this message]
2006-07-31  7:43                 ` Artem B. Bityutskiy
2006-07-31  9:29                   ` Frank Haverkamp
2006-07-31 13:52                   ` Josh Boyer
2006-07-31  8:09               ` Artem B. Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44CDAF7D.4040300@yandex.ru \
    --to=dedekind@yandex.ru \
    --cc=haver@vnet.ibm.com \
    --cc=joern@wohnheim.fh-wedel.de \
    --cc=jwboyer@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tim.marteo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.