From: John Byrne <john.l.byrne@hp.com>
To: Andrew Warfield <andrew.warfield@cl.cam.ac.uk>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: vbd flushing during migration?
Date: Mon, 31 Jul 2006 15:26:57 -0700 [thread overview]
Message-ID: <44CE83B1.1090605@hp.com> (raw)
In-Reply-To: <eacc82a40607311256s79c6b2a8tbdae53f6761fd39@mail.gmail.com>
It would be a bit ugly, but mostly straightforward to watch for the
destruction of the vbds (or all devices) after the destroyDomain() is
done and then sending an all-clear. (The last time I looked there wasn't
a waitForDomainDestroy() anywhere, so it would probably be best to write
one.) This would guarantee correctness: which is the most important thing.
The problem I see with that strategy is the effect on downtime during a
live-move. Ideally you'd like to start the vbd cleanup when the final
suspend is done and hope to parallelize the any final device operations
with the final pass of live-move. How to do that and play nice with
domain destruction on the normal path and handle errors seems a lot less
clear to me.
So, are you just ignoring the notion of minimizing downtime for the
moment or is there something I'm missing?
John
Andrew Warfield wrote:
> It's slightly more than a flush that's required. The migration
> protocol needs to be extended so that execution on the target host
> doesn't start until all of the outstanding (i.e. issued by the
> backend) block requests have been either cancelled or acknowledged.
> This should be pretty straight forward given that the backend driver
> ref counts a blkif's state based on pending requests, and won't tear
> down the backend directory in xenstore until all the outstanding
> requests have cleared. All that is likely required is to have the
> migration code register watches on the backend vbd directories, and
> wait for them to disappear before giving the all-clear to the new
> host.
>
> We've talked about this enough to know how to fix it, but haven't had
> a chance to hack it up. (I think Julian has looked into the problem a
> bit for blktap, but not yet done a general fix.) Patches would
> certainly be welcome though. ;)
>
> a.
>
> On 7/31/06, John Byrne <john.l.byrne@hp.com> wrote:
>>
>> Hi,
>>
>> I don't see any obvious flush to disk taking place for vbd's on the
>> source host in XendCheckpoint.py before the domain is started on the new
>> host. Is there a guarantee that all written data is on disk somewhere
>> else or is something needed?
>>
>> Thanks,
>>
>> John Byrne
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>>
>
next prev parent reply other threads:[~2006-07-31 22:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 19:39 vbd flushing during migration? John Byrne
2006-07-31 19:56 ` Andrew Warfield
2006-07-31 22:26 ` John Byrne [this message]
2006-07-31 23:03 ` Andrew Warfield
2006-08-01 19:28 ` Charles Coffing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CE83B1.1090605@hp.com \
--to=john.l.byrne@hp.com \
--cc=andrew.warfield@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.