All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Hua Zhong <hzhong@gmail.com>,
	"'Heiko Carstens'" <heiko.carstens@de.ibm.com>,
	"'Andrew Morton'" <akpm@osdl.org>,
	linux-kernel@vger.kernel.org,
	"'Martin Schwidefsky'" <schwidefsky@de.ibm.com>
Subject: Re: do { } while (0) question
Date: Tue, 01 Aug 2006 11:45:53 +0159	[thread overview]
Message-ID: <44CF22E8.9020307@gmail.com> (raw)
In-Reply-To: <1154425171.32739.2.camel@taijtu>

Peter Zijlstra wrote:
> On Tue, 2006-08-01 at 02:03 -0700, Hua Zhong wrote:
>>> #if KILLER == 1
>>> #define MACRO
>>> #else
>>> #define MACRO do { } while (0)
>>> #endif
>>>
>>> {
>>> 	if (some_condition)
>>> 		MACRO
>>>
>>> 	if_this_is_not_called_you_loose_your_data();
>>> }
>>>
>>> How do you want to define KILLER, 0 or 1? I personally choose 0.
>> Really? Does it compile?
> 
> No, and that is the whole point.
> 
> The empty 'do {} while (0)' makes the missing semicolon a syntax error.

Bulls^WNope, it was a bad example (we don't want to break the compilation, just 
not want to emit a warn or an err).

I can't emit an error with the thing like that, only a warning, but we are not 
using -Werror to get err from a warn. Thing such this would emit empty-statement 
warn if define KILLER as 1:
#if KILLER == 1
#define MACRO
#else
#define MACRO do { } while (0)
#endif

{
  	if (some_condition)
  		MACRO;
	else
		do_something();
}

regards,
-- 
<a href="http://www.fi.muni.cz/~xslaby/">Jiri Slaby</a>
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E

  reply	other threads:[~2006-08-01  9:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-01  8:21 do { } while (0) question Heiko Carstens
2006-08-01  8:45 ` Jonathan Matthews-Levine
2006-08-01  8:53   ` Heiko Carstens
2006-08-01 16:26     ` Andrew James Wade
2006-08-01  8:49 ` Andrew Morton
2006-08-01  8:52 ` Jiri Slaby
2006-08-01  9:03   ` Hua Zhong
2006-08-01  9:39     ` Peter Zijlstra
2006-08-01  9:46       ` Jiri Slaby [this message]
2006-08-01  9:57         ` Russell King
2006-08-01 10:04           ` Jiri Slaby
2006-08-01  9:59         ` Peter Zijlstra
2006-08-01 10:03           ` Jiri Slaby
2006-08-01 14:49   ` Horst H. von Brand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44CF22E8.9020307@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@osdl.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hzhong@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.