From: Joshua Brindle <jbrindle@tresys.com>
To: Karl MacMillan <kmacmillan@mentalrootkit.com>
Cc: SELinux List <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 1/2] Introduce symtab_datum_t
Date: Tue, 01 Aug 2006 08:29:53 -0400 [thread overview]
Message-ID: <44CF4941.9000400@tresys.com> (raw)
In-Reply-To: <1154357400.26550.77.camel@localhost.localdomain>
Karl MacMillan wrote:
> This patch adds a new structure - symtab_datum_t - and converts all of
> the datum types to place this struct as their first member. This unifies
> the storage of data common to all symtab datums and allows free casting
> between specific datum types (e.g., role_datum_t) and symtab_datum_t.
> This patch is large, but almost all of the changes are trivial.
>
> Karl
>
> checkpolicy/checkpolicy.c | 8 +-
> checkpolicy/module_compiler.c | 34 ++++-----
> checkpolicy/policy_parse.y | 102 ++++++++++++++---------------
> checkpolicy/test/dismod.c | 10 +-
> libsepol/include/sepol/policydb/policydb.h | 16 ++--
> libsepol/include/sepol/policydb/symtab.h | 11 +++
> libsepol/src/booleans.c | 2
> libsepol/src/conditional.c | 8 +-
> libsepol/src/context.c | 6 -
> libsepol/src/expand.c | 34 ++++-----
> libsepol/src/genusers.c | 2
> libsepol/src/hierarchy.c | 18 ++---
> libsepol/src/link.c | 54 +++++++--------
> libsepol/src/mls.c | 10 +-
> libsepol/src/policydb.c | 54 +++++++--------
> libsepol/src/services.c | 12 +--
> libsepol/src/users.c | 12 +--
> libsepol/src/util.c | 2
> libsepol/src/write.c | 16 ++--
> 19 files changed, 211 insertions(+), 200 deletions(-)
>
Looks good to me (other than my comment in the other patch).
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2006-08-01 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 14:50 [PATCH 1/2] Introduce symtab_datum_t Karl MacMillan
2006-08-01 12:29 ` Joshua Brindle [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-02 18:03 Ver 2 " kmacmillan
2006-08-02 18:03 ` [PATCH 1/2] " kmacmillan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CF4941.9000400@tresys.com \
--to=jbrindle@tresys.com \
--cc=kmacmillan@mentalrootkit.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.