From: Michael Reed <mdr@sgi.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/4] fusion: fibre channel: don't sync cache if remote port deleted
Date: Tue, 01 Aug 2006 10:37:26 -0500 [thread overview]
Message-ID: <44CF7536.5030006@sgi.com> (raw)
In-Reply-To: <1154444303.3446.11.camel@mulgrave.il.steeleye.com>
The mid-layer appears to be inconsistent with regard to sync cache.
I agree the sync should not be in the lldd. It's been in fusion for
a long time and I'm just fixing the implementation for fibre channel.
This isn't a new feature, just a fix to an existing one.
I refer you to two threads which discussed the issue.
http://marc.theaimsgroup.com/?l=linux-scsi&m=115386616817044&w=2
http://marc.theaimsgroup.com/?l=linux-scsi&m=115266599732078&w=2
Mike
James Bottomley wrote:
> On Mon, 2006-07-31 at 12:20 -0500, Michael Reed wrote:
>> mptscsih_slave_destroy issues an unconditional synchronize cache.
>
> A) mptscsih_slave_destroy shouldn't be doing this ... it should be
> relying on the functionality in the mid-layer.
>
>> It is not necessary for fibre channel devices for which the rport
>> has been deleted. This patch creates a new function,
>> mptfc_slave_destroy(), which implements the appropriate test.
>
> So, this is really code that shouldn't be in a driver, it should be
> higher up.
>
> The other three patches look fine.
>
> James
>
prev parent reply other threads:[~2006-08-01 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 17:20 [PATCH 4/4] fusion: fibre channel: don't sync cache if remote port deleted Michael Reed
2006-08-01 14:58 ` James Bottomley
2006-08-01 15:37 ` Michael Reed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CF7536.5030006@sgi.com \
--to=mdr@sgi.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.