From: "Jan Beulich" <jbeulich@novell.com>
To: "Stas Sergeev" <stsp@aknet.ru>
Cc: <76306.1226@compuserve.com>, <rohitseth@google.com>, <ak@muc.de>,
<akpm@osdl.org>, "Linux kernel" <linux-kernel@vger.kernel.org>,
"Zachary Amsden" <zach@vmware.com>
Subject: Re: + espfix-code-cleanup.patch added to -mm tree
Date: Tue, 01 Aug 2006 16:43:48 +0200 [thread overview]
Message-ID: <44CF84C4.76E4.0078.0@novell.com> (raw)
In-Reply-To: <44CF672E.9080906@aknet.ru>
>>> Well, someone used that macro in a .fixup section, where the
>>> CFI adjustments do not seem to work. But since I don't know
>>> why this was done (Jan?), I reverted that to my original code and
>>> added the adjustments now.
>> The macro in question is UNWIND_ESPFIX_STACK, which is used in
exactly
>No, that was about FIXUP_ESPFIX_STACK in fact.
>
>> Even more, the macro itself switches to .fixup,
>... where it uses FIXUP_ESPFIX_STACK. I haven't done that.
>Someone else added the .fixup section to UNWIND_ESPFIX_STACK,
>and so the FIXUP_ESPFIX_STACK became used in that section.
>I removed that now with my patch, unless someone can tell
>me why it was needed.
That was me, in order to get the unwind annotations right without
complicating the code too much. Again, FIXUP_ESPFIX_STACK doesn't
use any unwind directives so can be used anywhere, including the
.fixup section UNWIND_ESPFIX_STACK switches to.
Jan
next prev parent reply other threads:[~2006-08-01 14:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200607300016.k6U0GYu4023664@shell0.pdx.osdl.net>
2006-07-30 10:57 ` [patch] espfix code cleanup more Stas Sergeev
[not found] ` <44CE766D.6000705@vmware.com>
2006-08-01 12:21 ` + espfix-code-cleanup.patch added to -mm tree Stas Sergeev
2006-08-01 13:38 ` Jan Beulich
2006-08-01 14:37 ` Stas Sergeev
2006-08-01 14:43 ` Jan Beulich [this message]
2006-08-01 15:09 ` Stas Sergeev
2006-08-01 21:01 ` Zachary Amsden
2006-08-02 17:12 ` Stas Sergeev
2006-08-02 18:30 ` Zachary Amsden
2006-08-02 19:12 ` Stas Sergeev
2006-08-01 2:24 Chuck Ebbert
2006-08-01 12:39 ` Stas Sergeev
-- strict thread matches above, loose matches on Subject: below --
2006-08-02 19:14 Chuck Ebbert
2006-08-02 19:31 ` Stas Sergeev
2006-08-12 2:27 Chuck Ebbert
2006-08-12 10:35 ` Stas Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CF84C4.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=76306.1226@compuserve.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rohitseth@google.com \
--cc=stsp@aknet.ru \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.