Re: (usagi-core 30280) Re: [PATCH 10/23] [PATCH] [XFRM]: Trace which secpath state is reject factor.

[Masahide NAKAMURA <nakam@linux-ipv6.org>]

David Miller wrote:
> From: Masahide NAKAMURA <nakam@linux-ipv6.org>
> Date: Sat, 29 Jul 2006 18:30:29 +0900
> 
>> @@ -272,6 +272,9 @@ #define XFRM_TYPE_NON_FRAGMENT	1
>>  	void			(*destructor)(struct xfrm_state *);
>>  	int			(*input)(struct xfrm_state *, struct sk_buff *skb);
>>  	int			(*output)(struct xfrm_state *, struct sk_buff *pskb);
>> +#ifdef CONFIG_XFRM_ADVANCED
>> +	int			(*reject)(struct xfrm_state *, struct sk_buff *skb, struct flowi *);
>> +#endif
> 
> xfrm_secpath_reject() unconditionally dereferences this new reject
> operation pointer, but this patch contains no assignments of it.
> 
> Please send incremental patches that are fully functional all by
> themselves, so that if each one is applied, it would compile and
> work.

Thanks, I'll send so next time.

-- 
Masahide NAKAMURA