Patch to fix segfault in libselinux

Patch to fix segfault in libselinux

[Daniel J Walsh]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

* Tue Aug  1 2006 Jeremy Katz <katzj@redhat.com> - 1.30.19-5
- only build non-fpic objects with -mno-tls-direct-seg-refs

* Tue Aug  1 2006 Jeremy Katz <katzj@redhat.com> - 1.30.19-4
- build with -mno-tls-direct-seg-refs on x86 to avoid triggering
  segfaults with xen (#200783)  


[-- Attachment #2: libselinux-tlssegneg.patch --]
[-- Type: text/x-patch, Size: 683 bytes --]

--- libselinux-1.30.19/src/Makefile.notls	2006-08-01 14:16:38.000000000 -0400
+++ libselinux-1.30.19/src/Makefile	2006-08-01 14:37:15.000000000 -0400
@@ -24,6 +24,11 @@
 override CFLAGS += -I../include -I$(INCLUDEDIR) -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
 RANLIB=ranlib
 
+ARCH := $(patsubst i%86,i386,$(shell uname -m))
+ifneq (,$(filter i386,$(ARCH)))
+TLSFLAGS += -mno-tls-direct-seg-refs
+endif
+
 SWIG = swig -Wall -python -o $(SWIGCOUT) -outdir ./
 
 all: $(LIBA) $(LIBSO) 
@@ -45,7 +50,7 @@
 	ln -sf $@ $(TARGET) 
 
 %.o:  %.c policy.h
-	$(CC) $(CFLAGS) -c -o $@ $<
+	$(CC) $(CFLAGS) $(TLSFLAGS) -c -o $@ $<
 
 %.lo:  %.c policy.h
 	$(CC) $(CFLAGS) -fpic -DSHARED -c -o $@ $<

Re: Patch to fix segfault in libselinux

[Stephen Smalley]

On Wed, 2006-08-02 at 10:11 -0400, Daniel J Walsh wrote:
> * Tue Aug  1 2006 Jeremy Katz <katzj@redhat.com> - 1.30.19-5
> - only build non-fpic objects with -mno-tls-direct-seg-refs
> 
> * Tue Aug  1 2006 Jeremy Katz <katzj@redhat.com> - 1.30.19-4
> - build with -mno-tls-direct-seg-refs on x86 to avoid triggering
>   segfaults with xen (#200783)  

What's really at fault here, libselinux or xen?

-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: Patch to fix segfault in libselinux

[Daniel J Walsh]

Stephen Smalley wrote:
> On Wed, 2006-08-02 at 10:11 -0400, Daniel J Walsh wrote:
>   
>> * Tue Aug  1 2006 Jeremy Katz <katzj@redhat.com> - 1.30.19-5
>> - only build non-fpic objects with -mno-tls-direct-seg-refs
>>
>> * Tue Aug  1 2006 Jeremy Katz <katzj@redhat.com> - 1.30.19-4
>> - build with -mno-tls-direct-seg-refs on x86 to avoid triggering
>>   segfaults with xen (#200783)  
>>     
>
> What's really at fault here, libselinux or xen?
>
>   
libselinux in a threaded environment.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.