Re: [PATCH 4/8] acpi-cpufreq: remove ACPI from speedstep-centrino driver

[Alexey Starikovskiy <alexey_y_starikovskiy@linux.intel.com>]

Jeremy Fitzhardinge wrote:
> Alexey Starikovskiy wrote:
>> speedstep-centrino.c |  270
>> +++++++--------------------------------------------
>> 1 file changed, 40 insertions(+), 230 deletions(-)
>>
>> remove ACPI from speedstep-centrino driver
>>
>> Signed-off: Denis Sadykov <denis.m.sadykov@intel.com>
>> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi at intel.com>
>> Signed-off-by: Alexey Starikovskiy <alexey.y.starikovskiy at intel.com>
>>
>> Index: linux-2.6.17/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c
>> ===================================================================
>> ---
>> linux-2.6.17.orig/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c   
>> 2006-07-11 20:13:44.000000000 +0000
>> +++ linux-2.6.17/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c   
>> 2006-07-13 18:54:07.000000000 +0000
>> @@ -2,36 +2,36 @@
>>  * cpufreq driver for Enhanced SpeedStep, as found in Intel's Pentium
>>  * M (part of the Centrino chipset).
>>  *
>> - * Since the original Pentium M, most new Intel CPUs support Enhanced
>> - * SpeedStep.
>> - *
>>  * Despite the "SpeedStep" in the name, this is almost entirely unlike
>>  * traditional SpeedStep.
>>  *
>>  * Modelled on speedstep.c
>>  *
>>  * Copyright (C) 2003 Jeremy Fitzhardinge <jeremy@goop.org>
>> + *
>> + * WARNING WARNING WARNING
>> + *
>> + * This driver manipulates the PERF_CTL MSR, which is only somewhat
>> + * documented.  While it seems to work on my laptop, it has not been
>> + * tested anywhere else, and it may not work for you, do strange
>> + * things or simply crash.
>>  */
>> [...]
>> #define PFX        "speedstep-centrino: "
>> -#define MAINTAINER    "cpufreq@lists.linux.org.uk"
>> +#define MAINTAINER    "Jeremy Fitzhardinge <jeremy@goop.org>"
> 
> You're reverting a change I made recently.  Did you mean to?
> 
>    J
No. Intention was to remove ACPI only. Will post proper patch shortly.
Alex.