Re: [PATCH 3/8] acpi-cpufreq: merge acpi functionality of cpufreq drivers

[Alexey Starikovskiy <alexey_y_starikovskiy@linux.intel.com>]

Bruno Ducrot wrote:
> On Wed, Aug 02, 2006 at 10:44:34PM +0400, Alexey Starikovskiy wrote:
>> Bruno Ducrot wrote:
>>> I've not checked carrefully but it seems to me you are breaking
>>> powernow-k8.
>> We do not touch powernow-k8, and tried to make sure we do not change
>> acpi-cpufreq to exclude any unknown hardware. What we tried to do, is to merge
>> different ways of accessing cpufreq with ACPI under single driver. Could you be
>> more specific how we break powernow-k8?
> 
> I haven't seen the if (!check_speedstep_cpu(cpu)) {...} onto
> apci_cpufreq_cpu_init_acpi() indeed.
> 
> Therefore you are correct.
> 
> But it's funny to see that how acpi_cpufreq driver become
> so Intel specific.
> 
> If AMD or any other vendors want to add their stuff
> onto acpi_cpufreq, then should we accept their patches
> as well?
> 
I think so, it is written to handle that with minor modifications.