From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH] clean up pseries hcall interfaces
Date: Thu, 03 Aug 2006 14:17:30 -0700 [thread overview]
Message-ID: <44D267EA.8050103@am.sony.com> (raw)
In-Reply-To: <17617.30304.366738.986854@cargo.ozlabs.ibm.com>
Paul Mackerras wrote:
> Geoff Levand writes:
>
>> Change the scope of some pSeries routines now called through
>> ppc_md to static.
>
> With this I get:
>
> CC arch/powerpc/platforms/pseries/lpar.o
> /home/paulus/kernel/powerpc/arch/powerpc/platforms/pseries/lpar.c:273: error: static declaration of ^[$B!F^[(BpSeries_lpar_hpte_insert^[$B!G^[(B follows non-static declaration
> include2/asm/mmu.h:254: error: previous declaration of ^[$B!F^[(BpSeries_lpar_hpte_insert^[$B!G^[(B was here
> make[3]: *** [arch/powerpc/platforms/pseries/lpar.o] Error 1
OK, thanks for checking it. As I mentioned in my original
mail, it just looked like there could be some cleanup done,
but I didn't test it. I'll take a look at it some more and
see if I can make a proper re-work.
-Geoff
next prev parent reply other threads:[~2006-08-03 21:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 13:14 [PATCH] clean up pseries hcall interfaces Levand, Geoffrey
2006-07-25 14:41 ` Anton Blanchard
2006-07-25 20:55 ` Geoff Levand
2006-08-03 4:06 ` Paul Mackerras
2006-08-03 21:17 ` Geoff Levand [this message]
2006-10-05 18:35 ` Geoff Levand
-- strict thread matches above, loose matches on Subject: below --
2006-07-18 22:01 Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D267EA.8050103@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.