From: "Mika Penttilä" <mika.penttila@kolumbus.fi>
To: Keith Mannthey <kmannth@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, discuss@x86-64.org,
ak@suse.de, lhms-devel@lists.sourceforge.net,
kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [Lhms-devel] [PATCH 4/10] hot-add-mem x86_64: Enable SPARSEMEM in srat.c
Date: Fri, 04 Aug 2006 18:17:13 +0300 [thread overview]
Message-ID: <44D364F9.3080703@kolumbus.fi> (raw)
In-Reply-To: <20060804131409.21401.58904.sendpatchset@localhost.localdomain>
Keith Mannthey wrote:
> From: Keith Mannthey <kmannth@us.ibm.com>
>
> Enable x86_64 srat.c to share code between both reserve and sparsemem based add memory
> paths. Both paths need the hot-add area node locality infomration (nodes_add). This
> code refactors the code path to allow this.
>
> Signed-off-by: Keith Mannthey<kmannth@us.ibm.com>
>
Ok nice, but.... hotadd_enough_memory() is broken, it does weird things
with nd->start and nd->end which haven't been assigned even values yet.
Also, mysterious business with find_e820_area and last_area_end...These
areas are not in e820...
And why the reserve_bootmem_node()? Areas not RAM (per e820) are
reserved anyways.
--Mika
next prev parent reply other threads:[~2006-08-04 15:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-04 13:13 [PATCH 1/10] hot-add-mem x86_64: acpi motherboard fix Keith Mannthey
2006-08-04 13:13 ` [PATCH 2/10] hot-add-mem x86_64: fixup externs Keith Mannthey
2006-08-04 13:14 ` [PATCH 3/10] hot-add-mem x86_64: Kconfig changes Keith Mannthey
2006-08-04 13:14 ` [PATCH 4/10] hot-add-mem x86_64: Enable SPARSEMEM in srat.c Keith Mannthey
2006-08-04 15:17 ` Mika Penttilä [this message]
2006-08-04 19:36 ` [Lhms-devel] " keith mannthey
2006-08-04 17:42 ` Dave Hansen
2006-08-04 13:14 ` [PATCH 5/10] hot-add-mem x86_64: memory_add_physaddr_to_nid enable Keith Mannthey
2006-08-04 13:14 ` [PATCH 7/10] hot-add-mem x86_64: x86_64 kernel mapping fix Keith Mannthey
2006-08-04 13:14 ` [PATCH 8/10] hot-add-mem x86_64: use CONFIG_MEMORY_HOTPLUG_SPARSE Keith Mannthey
2006-08-04 13:14 ` [PATCH 9/10] hot-add-mem x86_64: use CONFIG_MEMORY_HOTPLUG_RESERVE Keith Mannthey
2006-08-07 17:41 ` keith mannthey
2006-08-04 13:14 ` [PATCH 10/10] hot-add-mem x86_64: valid add range check Keith Mannthey
2006-08-05 5:39 ` [PATCH 1/10] hot-add-mem x86_64: acpi motherboard fix KAMEZAWA Hiroyuki
2006-08-05 5:51 ` KAMEZAWA Hiroyuki
2006-08-07 18:39 ` keith mannthey
2006-08-08 0:31 ` [Lhms-devel] " KAMEZAWA Hiroyuki
2006-08-08 0:56 ` keith mannthey
2006-08-08 2:08 ` KAMEZAWA Hiroyuki
2006-08-08 2:15 ` keith mannthey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D364F9.3080703@kolumbus.fi \
--to=mika.penttila@kolumbus.fi \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kmannth@us.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.