From: Zachary Amsden <zach@vmware.com>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Jeremy Fitzhardinge <jeremy@xensource.com>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.osdl.org>
Subject: Re: [patch 3/8] Allow a kernel to not be in ring 0.
Date: Fri, 04 Aug 2006 21:26:23 -0700 [thread overview]
Message-ID: <44D41DEF.7040301@vmware.com> (raw)
In-Reply-To: <200608042045_MC3-1-C721-8608@compuserve.com>
Chuck Ebbert wrote:
> In-Reply-To: <20060803002518.190834642@xensource.com>
>
> On Wed, 02 Aug 2006 17:25:13 -0700, Jeremy Fitzhardinge wrote:
>
>
>> We allow for the fact that the guest kernel may not run in ring 0.
>> This requires some abstraction in a few places when setting %cs or
>> checking privilege level (user vs kernel).
>>
>
> I made some changes:
>
> a. Added some comments about the SEGMENT_IS_*_CODE() macros.
> b. Added a USER_RPL macro. (You were comparing a value to a mask
> in some places and to the magic number 3 in other places.)
> c. Changed the entry.S tests for LDT stack segment to use the macros.
>
These changes look great. Ack-ed. I had some similar ones before that
never made it from my tree, as I got carried away and tried to unify the
user descriptor conversion functions... someday I'll get to it again.
Zach
WARNING: multiple messages have this Message-ID (diff)
From: Zachary Amsden <zach@vmware.com>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: Jeremy Fitzhardinge <jeremy@xensource.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.osdl.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [patch 3/8] Allow a kernel to not be in ring 0.
Date: Fri, 04 Aug 2006 21:26:23 -0700 [thread overview]
Message-ID: <44D41DEF.7040301@vmware.com> (raw)
In-Reply-To: <200608042045_MC3-1-C721-8608@compuserve.com>
Chuck Ebbert wrote:
> In-Reply-To: <20060803002518.190834642@xensource.com>
>
> On Wed, 02 Aug 2006 17:25:13 -0700, Jeremy Fitzhardinge wrote:
>
>
>> We allow for the fact that the guest kernel may not run in ring 0.
>> This requires some abstraction in a few places when setting %cs or
>> checking privilege level (user vs kernel).
>>
>
> I made some changes:
>
> a. Added some comments about the SEGMENT_IS_*_CODE() macros.
> b. Added a USER_RPL macro. (You were comparing a value to a mask
> in some places and to the magic number 3 in other places.)
> c. Changed the entry.S tests for LDT stack segment to use the macros.
>
These changes look great. Ack-ed. I had some similar ones before that
never made it from my tree, as I got carried away and tried to unify the
user descriptor conversion functions... someday I'll get to it again.
Zach
next prev parent reply other threads:[~2006-08-05 4:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-05 0:41 [patch 3/8] Allow a kernel to not be in ring 0 Chuck Ebbert
2006-08-05 0:41 ` Chuck Ebbert
2006-08-05 4:26 ` Zachary Amsden [this message]
2006-08-05 4:26 ` Zachary Amsden
-- strict thread matches above, loose matches on Subject: below --
2006-08-05 5:40 Chuck Ebbert
2006-08-05 5:40 ` Chuck Ebbert
2006-08-03 0:25 [patch 0/8] Basic infrastructure patches for a paravirtualized kernel Jeremy Fitzhardinge
2006-08-03 0:25 ` [patch 3/8] Allow a kernel to not be in ring 0 Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D41DEF.7040301@vmware.com \
--to=zach@vmware.com \
--cc=76306.1226@compuserve.com \
--cc=jeremy@goop.org \
--cc=jeremy@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.