Re: [PATCH 2/5] [IPV6]: Multiple Routing Tables

[Patrick McHardy <kaber@trash.net>]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

Thomas Graf wrote:
> Index: net-2.6.19/net/ipv6/route.c
> ===================================================================
> --- net-2.6.19.orig/net/ipv6/route.c
> +++ net-2.6.19/net/ipv6/route.c
> @@ -1750,6 +1843,10 @@ static int rt6_fill_node(struct sk_buff 
>  	rtm->rtm_dst_len = rt->rt6i_dst.plen;
>  	rtm->rtm_src_len = rt->rt6i_src.plen;
>  	rtm->rtm_tos = 0;
> +	if (rt->rt6i_table)
> +		rtm->rtm_table = rt->rt6i_table->tb6_id;
> +	else
> +		rtm->rtm_table = RT6_TABLE_UNSPEC;
>  	rtm->rtm_table = RT_TABLE_MAIN;


This looks like a mistake, the table ID is overwritten again.


Signed-off-by: Patrick McHardy <kaber@trash.net>

[-- Attachment #2: x --]
[-- Type: text/plain, Size: 443 bytes --]

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index d5c39c4..3ea6db9 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -1898,7 +1898,6 @@ static int rt6_fill_node(struct sk_buff 
 		rtm->rtm_table = rt->rt6i_table->tb6_id;
 	else
 		rtm->rtm_table = RT6_TABLE_UNSPEC;
-	rtm->rtm_table = RT_TABLE_MAIN;
 	if (rt->rt6i_flags&RTF_REJECT)
 		rtm->rtm_type = RTN_UNREACHABLE;
 	else if (rt->rt6i_dev && (rt->rt6i_dev->flags&IFF_LOOPBACK))