From: "H. Peter Anvin" <hpa@zytor.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andi Kleen <ak@muc.de>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Turn rdmsr, rdtsc into inline functions, clarify names
Date: Sat, 05 Aug 2006 19:58:52 -0700 [thread overview]
Message-ID: <44D55AEC.1090205@zytor.com> (raw)
In-Reply-To: <1154832963.29151.21.camel@localhost.localdomain>
Rusty Russell wrote:
>
> You mean the l and ll variants? The 64 bit variants are rdmsrl and
> rdtscll, not to be confused with rdtscl, which returns the lower 32
> bits. This confusion caused the x86_64 bug in gameport.c which the
> patch comment mentioned (at least, seems to be a bug to me).
>
> See why I want to fix these names?
>
> So if you would prefer u64 rdtsc64(), u32 rdtsc_low(), u64 rdmsr64(int
> msr), u32 rdmsr_low(int msr), I can convert everyone to that, although
> it's a more invasive change...
rdmsrl is really misnamed. It should have been rdmsrq to be consistent,
and have rdmsrl return the low 32 bits.
-hpa
next prev parent reply other threads:[~2006-08-06 2:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1154771262.28257.38.camel@localhost.localdomain>
2006-08-06 2:38 ` [PATCH] Turn rdmsr, rdtsc into inline functions, clarify names Andi Kleen
2006-08-06 2:56 ` Rusty Russell
2006-08-06 2:58 ` H. Peter Anvin [this message]
2006-08-06 3:09 ` Rusty Russell
2006-08-06 3:11 ` H. Peter Anvin
2006-08-06 3:49 ` Rusty Russell
2006-08-06 3:16 ` Andi Kleen
2006-08-06 3:52 ` Rusty Russell
2006-08-06 14:58 ` Andi Kleen
2006-08-07 2:43 ` Dmitry Torokhov
2006-08-07 8:48 ` Andi Kleen
2006-08-07 11:09 ` Vojtech Pavlik
2006-08-07 12:28 ` Andi Kleen
2006-08-07 12:48 ` Vojtech Pavlik
2006-08-07 12:56 ` Andi Kleen
2006-08-07 13:18 ` Vojtech Pavlik
2006-08-07 13:32 ` Dmitry Torokhov
2006-08-07 15:01 ` Andi Kleen
2006-08-07 15:19 ` Andreas Mohr
2006-08-07 15:57 ` Andi Kleen
2006-08-07 16:04 ` Vojtech Pavlik
2006-08-07 16:12 ` Andi Kleen
2006-08-07 19:22 ` Vojtech Pavlik
2006-08-14 20:13 ` Pavel Machek
2006-08-07 11:07 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D55AEC.1090205@zytor.com \
--to=hpa@zytor.com \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.