From: Jeff Garzik <jeff@garzik.org>
To: Kyle McMartin <kyle@parisc-linux.org>
Cc: netdev@vger.kernel.org, grundler@parisc-linux.org,
val_henson@linux.intel.com, akpm@osdl.org
Subject: Re: [PATCH 4/9] [TULIP] Clean tulip.h so it can be used by winbond-840.c
Date: Wed, 09 Aug 2006 01:33:18 -0400 [thread overview]
Message-ID: <44D9739E.905@garzik.org> (raw)
In-Reply-To: <115498403384-git-send-email-kyle@parisc-linux.org>
Kyle McMartin wrote:
> From: Grant Grundler <grundler@parisc-linux.org>
>
> Include "tulip.h" in winbond-840.c and clean up lots of redundant
> definitions.
>
> Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
> Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
> ---
> drivers/net/tulip/tulip.h | 17 ++++++----
> drivers/net/tulip/tulip_core.c | 7 +---
> drivers/net/tulip/winbond-840.c | 68 ++++++++++++++-------------------------
> 3 files changed, 37 insertions(+), 55 deletions(-)
>
> diff --git a/drivers/net/tulip/tulip.h b/drivers/net/tulip/tulip.h
> index d79c7ae..951af5e 100644
> --- a/drivers/net/tulip/tulip.h
> +++ b/drivers/net/tulip/tulip.h
> @@ -30,11 +30,10 @@ #include <asm/irq.h>
> /* undefine, or define to various debugging levels (>4 == obscene levels) */
> #define TULIP_DEBUG 1
>
> -/* undefine USE_IO_OPS for MMIO, define for PIO */
> #ifdef CONFIG_TULIP_MMIO
> -# undef USE_IO_OPS
> +#define TULIP_BAR 1 /* CBMA */
> #else
> -# define USE_IO_OPS 1
> +#define TULIP_BAR 0 /* CBIO */
> #endif
OK except for two things:
1) should be split up into two patches: modify tulip, and modify winbond
2) nobody (but parisc folks?) knows what CBMA and CBIO mean. Just use
"MMIO" and "PIO"
next prev parent reply other threads:[~2006-08-09 5:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 20:44 [PATCH 0/9] tulip patches from parisc-linux Kyle McMartin
2006-08-07 20:53 ` [PATCH 1/9] [TULIP] Fix PHY init and reset Kyle McMartin
2006-08-07 20:53 ` [PATCH 2/9] [TULIP] Print physical address in tulip_init_one Kyle McMartin
2006-08-07 20:53 ` [PATCH 3/9] [TULIP] Make tulip_stop_rxtx() failure case slightly more informative Kyle McMartin
2006-08-07 20:53 ` [PATCH 4/9] [TULIP] Clean tulip.h so it can be used by winbond-840.c Kyle McMartin
2006-08-07 20:53 ` [PATCH 5/9] [TULIP] Flush MMIO writes in reset sequence Kyle McMartin
2006-08-07 20:53 ` [PATCH 6/9] [TULIP] Fix IRQ/DMA race Kyle McMartin
2006-08-07 20:53 ` [PATCH 7/9] [TULIP] Defer tulip_select_media() to process context Kyle McMartin
2006-08-07 20:53 ` [PATCH 8/9] [TULIP] Make DS21143 printout match lspci output Kyle McMartin
2006-08-07 20:53 ` [PATCH 9/9] [TULIP] Fix section mismatch in de2104x.c Kyle McMartin
2006-08-09 5:37 ` Jeff Garzik
2006-08-09 5:36 ` [PATCH 8/9] [TULIP] Make DS21143 printout match lspci output Jeff Garzik
2006-08-09 5:35 ` [PATCH 6/9] [TULIP] Fix IRQ/DMA race Jeff Garzik
2006-08-09 6:44 ` Valerie Henson
2006-08-09 5:33 ` [PATCH 5/9] [TULIP] Flush MMIO writes in reset sequence Jeff Garzik
2006-08-09 5:33 ` Jeff Garzik [this message]
2006-08-09 15:00 ` [PATCH 4/9] [TULIP] Clean tulip.h so it can be used by winbond-840.c Grant Grundler
2006-08-10 12:26 ` Jeff Garzik
2006-08-09 5:30 ` [PATCH 3/9] [TULIP] Make tulip_stop_rxtx() failure case slightly more informative Jeff Garzik
2006-08-09 5:29 ` [PATCH 1/9] [TULIP] Fix PHY init and reset Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D9739E.905@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=grundler@parisc-linux.org \
--cc=kyle@parisc-linux.org \
--cc=netdev@vger.kernel.org \
--cc=val_henson@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.