* [NETFILTER 01/02]: xt_string: fix negation
@ 2006-08-09 9:41 Patrick McHardy
2006-08-10 23:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Patrick McHardy @ 2006-08-09 9:41 UTC (permalink / raw)
To: David S. Miller; +Cc: Netfilter Development Mailinglist
[-- Attachment #1: Type: text/plain, Size: 85 bytes --]
Hi Dave,
following are two small netfilter fixes for 2.6.18.
Please apply, thanks.
[-- Attachment #2: 01.diff --]
[-- Type: text/plain, Size: 1097 bytes --]
[NETFILTER]: xt_string: fix negation
The xt_string match is broken with ! negation.
This resolves a portion of netfilter bugzilla #497.
Signed-off-by: Phil Oester <kernel@linuxace.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit 71c55528be7cf1199376a1b1c5489f60bf2b2617
tree 9a3262f5694c8eb859852981536baa874d3b0fab
parent 9f737633e6ee54fc174282d49b2559bd2208391d
author Phil Oester <kaber@trash.net> Tue, 08 Aug 2006 11:09:06 +0200
committer Patrick McHardy <kaber@trash.net> Tue, 08 Aug 2006 11:09:06 +0200
net/netfilter/xt_string.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/xt_string.c b/net/netfilter/xt_string.c
index d8e3891..275330f 100644
--- a/net/netfilter/xt_string.c
+++ b/net/netfilter/xt_string.c
@@ -37,7 +37,7 @@ static int match(const struct sk_buff *s
return (skb_find_text((struct sk_buff *)skb, conf->from_offset,
conf->to_offset, conf->config, &state)
- != UINT_MAX) && !conf->invert;
+ != UINT_MAX) ^ conf->invert;
}
#define STRING_TEXT_PRIV(m) ((struct xt_string_info *) m)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [NETFILTER 01/02]: xt_string: fix negation
2006-08-09 9:41 [NETFILTER 01/02]: xt_string: fix negation Patrick McHardy
@ 2006-08-10 23:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-08-10 23:57 UTC (permalink / raw)
To: kaber; +Cc: netfilter-devel
From: Patrick McHardy <kaber@trash.net>
Date: Wed, 09 Aug 2006 11:41:24 +0200
> following are two small netfilter fixes for 2.6.18.
> Please apply, thanks.
Both applied, thanks Patrick.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-10 23:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-09 9:41 [NETFILTER 01/02]: xt_string: fix negation Patrick McHardy
2006-08-10 23:57 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.