All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: Olaf Hering <olaf@aepfle.de>, Lee Revell <rlrevell@joe-job.com>,
	alsa-devel@alsa-project.org
Subject: Re: Linux v2.6.18-rc4, snd-aoa link error
Date: Wed, 09 Aug 2006 11:58:22 +0200	[thread overview]
Message-ID: <44D9B1BE.9070600@sipsolutions.net> (raw)
In-Reply-To: <s5hoduudypc.wl%tiwai@suse.de>

Takashi Iwai wrote:
>> --- aoa/Kconfig~	2006-08-08 16:02:30.000000000 -0400
>> +++ aoa/Kconfig	2006-08-08 16:03:26.000000000 -0400
>> @@ -5,6 +5,7 @@
>>  	tristate "Apple Onboard Audio driver"
>>  	depends on SND
>>  	select SND_PCM
>> +	select I2C
>>  	---help---
>>  	This option enables the new driver for the various
>>  	Apple Onboard Audio components.
>>     
>
> Maybe better to put it in aoa/codecs/Kconfig.
> The requirement of i2c is not in the core part of aoa driver but in
> the codec support codes.
>   
Yes, each codec except for toonie should select I2C. Looks like I missed 
that, sorry.

However, I was recently told that the expected behaviour with I2C (in a 
thread discussing the motion sensor) that I2C should be depended upon, 
not selected. I very much disagree (*), however, and would like to see a 
select here.

Unfortunately, I started new work in Nürnberg, don't have any internet 
at home right now and am not supposed to bring my own laptop to work. 
Would someone else create the required patch?
> Should I2C_POWERMANC be selected, too?
It makes sense since the aoa driver is specific to machines that have 
the i2c powermac bus, but I'm ambivalent about it. Though, does the G5 
require I2C_POWERMAC? I'm not completely sure about that.

johannes

(*) I don't think it makes sense to bother someone configuring the 
kernel with the some concept called I2C. The user should be able to just 
select the sound driver necessary.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

  reply	other threads:[~2006-08-09  9:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-06 18:35 Linux v2.6.18-rc4 Linus Torvalds
2006-08-06 22:48 ` Greg KH
2006-08-07  5:06   ` Al Viro
2006-08-07 15:08 ` Mike Galbraith
2006-08-07 17:32   ` H. Peter Anvin
2006-08-07 17:50     ` Greg KH
2006-08-07 17:56       ` Dave Jones
2006-08-07 18:59         ` Greg KH
2006-08-07 17:52     ` Jan Engelhardt
2006-08-07 17:57       ` Dave Jones
2006-08-07 17:59       ` H. Peter Anvin
2006-08-07 19:14         ` Greg KH
2006-08-07 19:32           ` H. Peter Anvin
2006-08-08  8:59 ` 2.6.18-rc4: Lukewarm IQ Mike Galbraith
2006-08-08 17:47 ` Linux v2.6.18-rc4 Jan Engelhardt
2006-08-08 18:24   ` Patrick McHardy
2006-08-08 19:46 ` Linux v2.6.18-rc4, snd-aoa link error Olaf Hering
2006-08-08 20:03   ` Lee Revell
2006-08-09  9:51     ` Takashi Iwai
2006-08-09  9:58       ` Johannes Berg [this message]
2006-08-09 10:38         ` Takashi Iwai
2006-08-09 11:37           ` Johannes Berg
2006-08-09 12:18             ` Takashi Iwai
2006-08-09 12:29               ` Johannes Berg
2006-08-09 12:29                 ` [Alsa-devel] " Johannes Berg
2006-08-09 12:31                 ` Takashi Iwai
2006-08-09 12:38                   ` Johannes Berg
2006-08-09 12:38                     ` [Alsa-devel] " Johannes Berg
2006-08-09 12:52                     ` Takashi Iwai
2006-08-09 12:52                       ` [Alsa-devel] " Takashi Iwai
2006-08-09 12:31                 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44D9B1BE.9070600@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=olaf@aepfle.de \
    --cc=rlrevell@joe-job.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.